Re: [systemd-devel] [PATCH] Added test for unit file state returned by unit_file_get_state and unit_file_get_list.

2014-10-05 Thread Ken Sedgwick
Will do. Ken On Sun, Oct 5, 2014 at 2:27 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Fri, Oct 03, 2014 at 04:03:14PM -0700, Ken Sedgwick wrote: +const char *subdir = /test-enabled-root; +char root_dir[UNIT_NAME_MAX + 2 + 1] = TEST_DIR; + +#define

Re: [systemd-devel] [PATCH] Added test for unit file state returned by unit_file_get_state and unit_file_get_list.

2014-10-04 Thread David Timothy Strauss
It would be good if the test units were more basic, not things including Crash recovery kernel arming. This makes it seems like the contents are substantial to the tests, when they're not. Just run something like ExecStart=/usr/bin/echo to make it clear that the units are stubs. Then, anything but

[systemd-devel] [PATCH] Added test for unit file state returned by unit_file_get_state and unit_file_get_list.

2014-10-03 Thread Ken Sedgwick
--- .gitignore | 1 + Makefile.am| 44 ++- src/test/test-enabled.c| 143 + .../etc/systemd/system/masked.service | 1 +

Re: [systemd-devel] [PATCH] Added test for unit file state returned by unit_file_get_state and unit_file_get_list.

2014-10-03 Thread David Timothy Strauss
Just to give some context, at Pantheon, we're working on optimizations for the enabled part of systemd core. The first step we're doing is enhancing the test suite. The additions here pass on master and will also pass with the changes we'll submit after more tests are in core.