Re: [systemd-devel] [PATCH] Fix memory leak in stdout journal streams

2013-12-08 Thread David Timothy Strauss
On Sun, Dec 8, 2013 at 12:23 PM, Dan McGee wrote: > It is the "free(s->buffer);" bit that snuck in there from the other patches > I sent this morning. I can rebase this one before those so it applies to the > current tree, my mistake. Aha! Applied. Thanks.

[systemd-devel] [PATCH] Fix memory leak in stdout journal streams

2013-12-08 Thread Dan McGee
Just as 'identifier' is strdup-ed and freed, we need to do the same for unit_id. --- src/journal/journald-stream.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/journal/journald-stream.c b/src/journal/journald-stream.c index 9ca26e2..091f59d 100644 --- a/src/journal/journald-stream.c +++

Re: [systemd-devel] [PATCH] Fix memory leak in stdout journal streams

2013-12-08 Thread Dan McGee
On Sun, Dec 8, 2013 at 1:56 PM, David Timothy Strauss < da...@davidstrauss.net> wrote: > This fails to apply for me. Just to check yours methods and mine, I > tried applying your "Ensure unit is journaled for short-lived or > oneshot processes" patch and succeeded. Comparing the two, it looks > li

Re: [systemd-devel] [PATCH] Fix memory leak in stdout journal streams

2013-12-08 Thread David Timothy Strauss
This fails to apply for me. Just to check yours methods and mine, I tried applying your "Ensure unit is journaled for short-lived or oneshot processes" patch and succeeded. Comparing the two, it looks like the text above the first triple-hyphen got dropped. _

[systemd-devel] [PATCH] Fix memory leak in stdout journal streams

2013-12-08 Thread Dan McGee
--- src/journal/journald-stream.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/journal/journald-stream.c b/src/journal/journald-stream.c index 890c0bf..eb9ea36 100644 --- a/src/journal/journald-stream.c +++ b/src/journal/journald-stream.c @@ -360,6 +360,7 @@ void stdout_stream_free(Stdo