Re: [systemd-devel] [PATCH] Fix starting swap unit on symlink made it unstoppable

2012-11-21 Thread jjacky
On 10/29/12 11:03, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Oct 23, 2012 at 10:15:00PM +0200, jjacky wrote: >> >> On 10/23/12 21:05, Lennart Poettering wrote: >>> On Sat, 13.10.12 14:24, Olivier Brunel (i.am.jack.m...@gmail.com) wrote: >>> Starting a swap unit pointing to (What) a symlin

Re: [systemd-devel] [PATCH] Fix starting swap unit on symlink made it unstoppable

2012-10-29 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 23, 2012 at 10:15:00PM +0200, jjacky wrote: > > On 10/23/12 21:05, Lennart Poettering wrote: > > On Sat, 13.10.12 14:24, Olivier Brunel (i.am.jack.m...@gmail.com) wrote: > > > >> Starting a swap unit pointing to (What) a symlink (e.g. /dev/mapper/swap > >> or /dev/disk/by-uuid/...) wo

Re: [systemd-devel] [PATCH] Fix starting swap unit on symlink made it unstoppable

2012-10-23 Thread jjacky
On 10/23/12 21:05, Lennart Poettering wrote: > On Sat, 13.10.12 14:24, Olivier Brunel (i.am.jack.m...@gmail.com) wrote: > >> Starting a swap unit pointing to (What) a symlink (e.g. /dev/mapper/swap >> or /dev/disk/by-uuid/...) would have said unit be marked active, follow >> the one using the "ac

Re: [systemd-devel] [PATCH] Fix starting swap unit on symlink made it unstoppable

2012-10-23 Thread Lennart Poettering
On Sat, 13.10.12 14:24, Olivier Brunel (i.am.jack.m...@gmail.com) wrote: > Starting a swap unit pointing to (What) a symlink (e.g. /dev/mapper/swap > or /dev/disk/by-uuid/...) would have said unit be marked active, follow > the one using the "actual" device (/dev/{dm-1,sda3}), but that new unit >

Re: [systemd-devel] [PATCH] Fix starting swap unit on symlink made it unstoppable

2012-10-13 Thread Colin Guthrie
'Twas brillig, and jjacky at 13/10/12 13:58 did gyre and gimble: > Forgot to say: not stopping the swap also meant that, with encrypted > swaps, the LUKS device couldn't be detached (since it's still in use) > and would result in errors on shutdown: > > systemd-cryptsetup[3327]: Failed to deactiva

Re: [systemd-devel] [PATCH] Fix starting swap unit on symlink made it unstoppable

2012-10-13 Thread jjacky
Forgot to say: not stopping the swap also meant that, with encrypted swaps, the LUKS device couldn't be detached (since it's still in use) and would result in errors on shutdown: systemd-cryptsetup[3327]: Failed to deactivate: Invalid argument ___ system

[systemd-devel] [PATCH] Fix starting swap unit on symlink made it unstoppable

2012-10-13 Thread Olivier Brunel
Starting a swap unit pointing to (What) a symlink (e.g. /dev/mapper/swap or /dev/disk/by-uuid/...) would have said unit be marked active, follow the one using the "actual" device (/dev/{dm-1,sda3}), but that new unit would be seen as inactive. Since all requests to stop swap units would follow/redi