Re: [systemd-devel] [PATCH] Pass environment over daemon-reexec

2013-02-08 Thread Tollef Fog Heen
]] Lennart Poettering > So, humm, are environment vars allowed to include newlines? Should we > filter them out? We need to do some research... IFS traditionally contains a newline. AFAIK env vars can contain anything but nulls, including invalid UTF-8 -- Tollef Fog Heen UNIX is user friendl

[systemd-devel] [PATCH] Pass environment over daemon-reexec

2013-02-08 Thread Oleksii Shevchuk
Fixes this bug: alxchk > systemctl --user set-environment A=B alxchk > systemctl --user show-environment | grep ^A= A=B alxchk > systemctl --user daemon-reexec alxchk > systemctl --user show-environment | grep ^A= alxchk > alxchk > dctl set-environment A=$(echo -e "A\nB") alxchk > dctl show-environ

Re: [systemd-devel] [PATCH] Pass environment over daemon-reexec

2013-02-07 Thread Oleksii Shevchuk
> and it doesn't seem to do anything :( Ah, and I miss something. If you are NOT testing it in your working instance, you should patch main.c to reexec that one, that you are testing. Because binary for reexec hardcoded to main.c as for now. So you can just get default systemd after reexec, that k

Re: [systemd-devel] [PATCH] Pass environment over daemon-reexec

2013-02-07 Thread Oleksii Shevchuk
> and it doesn't seem to do anything :( If you running it in your working instance, you should reexec twice, to get that systemd, that serializes env to next. > Now, I wonder if nelines in env vars is actually OK or not. Yes, I thought about it too. As for now, there is not proper support for \

Re: [systemd-devel] [PATCH] Pass environment over daemon-reexec

2013-02-07 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 08, 2013 at 01:36:26AM +0100, Lennart Poettering wrote: > On Thu, 07.02.13 00:40, Oleksii Shevchuk (alx...@gmail.com) wrote: > > > Fixes this bug: > > alxchk > systemctl --user set-environment A=B > > alxchk > systemctl --user show-environment | grep ^A= > > A=B > > alxchk > systemctl

Re: [systemd-devel] [PATCH] Pass environment over daemon-reexec

2013-02-07 Thread Lennart Poettering
On Thu, 07.02.13 00:40, Oleksii Shevchuk (alx...@gmail.com) wrote: > Fixes this bug: > alxchk > systemctl --user set-environment A=B > alxchk > systemctl --user show-environment | grep ^A= > A=B > alxchk > systemctl --user daemon-reexec > alxchk > systemctl --user show-environment | grep ^A= > alx

[systemd-devel] [PATCH] Pass environment over daemon-reexec

2013-02-06 Thread Oleksii Shevchuk
Fixes this bug: alxchk > systemctl --user set-environment A=B alxchk > systemctl --user show-environment | grep ^A= A=B alxchk > systemctl --user daemon-reexec alxchk > systemctl --user show-environment | grep ^A= alxchk > --- src/core/manager.c | 18 ++ 1 file changed, 18 insertio