Re: [systemd-devel] [PATCH] Propagate reload from RELOADING=1 notifications

2015-02-02 Thread Lennart Poettering
On Tue, 30.12.14 20:22, Jouke Witteveen (j.wittev...@gmail.com) wrote: Hmm, what happened to this patch? Did you ever resend it with the commit msg fix Zbigniew suggested? I don't see it in the mail archives? --- This fixes #87251 src/core/manager.c | 42

Re: [systemd-devel] [PATCH] Propagate reload from RELOADING=1 notifications

2015-02-02 Thread Lennart Poettering
On Thu, 01.01.15 19:15, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Tue, Dec 30, 2014 at 08:22:27PM +0100, Jouke Witteveen wrote: --- This fixes #87251 This is actually important information that should be included in the commit message (i.e. above not below ---). We

Re: [systemd-devel] [PATCH] Propagate reload from RELOADING=1 notifications

2015-02-02 Thread Lennart Poettering
On Tue, 06.01.15 16:33, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: Isn't that just bad behavior? Sending a RELOADING=1 notification after a reload is initiated? I guess if both service_enter_reload() and service_enter_reload_by_notify() are called it is justified to propagate

Re: [systemd-devel] [PATCH] Propagate reload from RELOADING=1 notifications

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 30, 2014 at 08:22:27PM +0100, Jouke Witteveen wrote: --- This fixes #87251 This is actually important information that should be included in the commit message (i.e. above not below ---). We usually include the full url, since we also use distribution bug trackers and having the

Re: [systemd-devel] [PATCH] Propagate reload from RELOADING=1 notifications

2015-01-01 Thread Jouke Witteveen
On Thu, Jan 1, 2015 at 7:15 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Dec 30, 2014 at 08:22:27PM +0100, Jouke Witteveen wrote: --- This fixes #87251 This is actually important information that should be included in the commit message (i.e. above not below ---). We

[systemd-devel] [PATCH] Propagate reload from RELOADING=1 notifications

2014-12-30 Thread Jouke Witteveen
--- This fixes #87251 src/core/manager.c | 42 ++ src/core/manager.h | 1 + src/core/service.c | 7 +++ 3 files changed, 50 insertions(+) diff --git a/src/core/manager.c b/src/core/manager.c index 9705e64..11cca17 100644 --- a/src/core/manager.c