Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Michael Biebl
2014-12-20 3:05 GMT+01:00 Michael Biebl : > Basically you can take my patch and drop the junk which removes the Heh, this should be "hunk", of course . Why is it that you spot the typo the second you press send :-) Michael -- Why is it that all of the instruments seeking intelligent life in the

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Michael Biebl
2014-12-20 0:23 GMT+01:00 Tom Gundersen : > On Fri, Dec 19, 2014 at 3:32 PM, Michael Biebl wrote: >> Here is an updated patch, using "conditional"s as suggested by >> Makefile-man.am and regenerating Makefile-man.am by running "make >> update-man-list" >> >> This also removed the HAVE_PYTHON secti

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Tom Gundersen
On Fri, Dec 19, 2014 at 3:32 PM, Michael Biebl wrote: > Here is an updated patch, using "conditional"s as suggested by > Makefile-man.am and regenerating Makefile-man.am by running "make > update-man-list" > > This also removed the HAVE_PYTHON section from Makefile-man.am. Why it > did that is unc

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 19, 2014 at 08:42:13AM -0800, Filipe Brandenburger wrote: > On Fri, Dec 19, 2014 at 8:31 AM, Michael Biebl wrote: > > 2014-12-19 17:10 GMT+01:00 Filipe Brandenburger : > >> On Fri, Dec 19, 2014 at 6:32 AM, Michael Biebl wrote: > >>> This also removed the HAVE_PYTHON section from Makef

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Filipe Brandenburger
On Fri, Dec 19, 2014 at 8:31 AM, Michael Biebl wrote: > 2014-12-19 17:10 GMT+01:00 Filipe Brandenburger : >> On Fri, Dec 19, 2014 at 6:32 AM, Michael Biebl wrote: >>> This also removed the HAVE_PYTHON section from Makefile-man.am. Why it >>> did that is unclear to me. >> >> This happened to me be

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Michael Biebl
2014-12-19 17:10 GMT+01:00 Filipe Brandenburger : > On Fri, Dec 19, 2014 at 6:32 AM, Michael Biebl wrote: >> This also removed the HAVE_PYTHON section from Makefile-man.am. Why it >> did that is unclear to me. > > This happened to me before and when it did it was because ./configure > didn't detec

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Filipe Brandenburger
On Fri, Dec 19, 2014 at 6:32 AM, Michael Biebl wrote: > This also removed the HAVE_PYTHON section from Makefile-man.am. Why it > did that is unclear to me. This happened to me before and when it did it was because ./configure didn't detect a working Python, so "make update-man-list" didn't use on

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Michael Biebl
Here is an updated patch, using "conditional"s as suggested by Makefile-man.am and regenerating Makefile-man.am by running "make update-man-list" This also removed the HAVE_PYTHON section from Makefile-man.am. Why it did that is unclear to me. Maybe Zbigniew can chime in here. 2014-12-19 15:24 G

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Umut Tezduyar Lindskog
:) See my second patch's comment Michael. On Fri, Dec 19, 2014 at 3:17 PM, Michael Biebl wrote: > That said, Makefile-man.am contains a comment, that this file > shouldn't be edited directly but rather be updated via "make > update-man-list" > > 2014-12-19 15:12 GMT+01:00 Michael Biebl : >> +if E

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Michael Biebl
That said, Makefile-man.am contains a comment, that this file shouldn't be edited directly but rather be updated via "make update-man-list" 2014-12-19 15:12 GMT+01:00 Michael Biebl : > +if ENABLE_HWDB > +MANPAGES += \ > +man/hwdb.7 > +man/systemd-hwdb.xml > > Shouldn't this rather

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Michael Biebl
+if ENABLE_HWDB +MANPAGES += \ +man/hwdb.7 +man/systemd-hwdb.xml Shouldn't this rather be systemd-hwdb.8 ? I also don't see a reason to remove man/systemd-hwdb.xml from EXTRA_DIST. You want to include that file in the dist tarball always. 2014-12-19 13:25 GMT+01:00 Tom Gundersen

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Tom Gundersen
Hm, this broke the manpage building: $ ./autogen.sh c && make man/systemd-hwdb.8 [...] make: *** No rule to make target 'man/systemd-hwdb.xml', needed by 'man/systemd-hwdb.8'. Stop. Care to take a look? Cheers, Tom On Fri, Dec 19, 2014 at 11:47 AM, Umut Tezduyar Lindskog wrote: > --- > Make

[systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Umut Tezduyar Lindskog
--- Makefile-man.am | 9 ++--- Makefile.am | 2 ++ configure.ac| 6 ++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/Makefile-man.am b/Makefile-man.am index 45b8238..c6506aa 100644 --- a/Makefile-man.am +++ b/Makefile-man.am @@ -14,7 +14,6 @@ MANPAGES += \