Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
Lennart Poettering writes: > Hmm, why do you bother with the tests only appearing on > noinst_PROGRAMS= anyway? Those are never run automatically, so they > shouldn't matter to you? Well, at the moment, one of them (test-bus-marshal) fails to link due to (seemingly) a problem with glib linking.

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 19:25, Henrik Grindal Bakken (h...@ifi.uio.no) wrote: > > Lennart Poettering writes: > > > On Wed, 17.04.13 18:48, Henrik Grindal Bakken (h...@ifi.uio.no) wrote: > > > >> @@ -125,8 +125,13 @@ dist_dbussystemservice_DATA = > >> check_PROGRAMS = > >> check_DATA = > >> noinst_t

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
Lennart Poettering writes: > On Wed, 17.04.13 18:48, Henrik Grindal Bakken (h...@ifi.uio.no) wrote: > >> @@ -125,8 +125,13 @@ dist_dbussystemservice_DATA = >> check_PROGRAMS = >> check_DATA = >> noinst_tests= >> +if ENABLE_TESTS >> noinst_PROGRAMS = $(noinst_tests) >> TESTS = $(noinst_tests)

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 18:48, Henrik Grindal Bakken (h...@ifi.uio.no) wrote: > @@ -125,8 +125,13 @@ dist_dbussystemservice_DATA = > check_PROGRAMS = > check_DATA = > noinst_tests= > +if ENABLE_TESTS > noinst_PROGRAMS = $(noinst_tests) > TESTS = $(noinst_tests) > +else > +noinst_PROGRAMS = > +TESTS

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
Lennart Poettering writes: > noinst_PROGRAMS is for tests that cannot really be run > automatically during "make check", since they need some kind of > interaction, priviliges and so on. These tests are much less useful, but > for some low level stuff we need this. > > noinst_tests otoh is for te

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 18:38, Henrik Grindal Bakken (h...@ifi.uio.no) wrote: > > Kay Sievers writes: > > > On Wed, Apr 17, 2013 at 5:49 PM, Henrik Grindal Bakken > > wrote: > >> This patch adds --disable-tests to configure. It is based on a patch > >> posted by Thierry Reding in 2010. The motivat

[systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
This patch adds --disable-tests to configure. It is based on a patch posted by Thierry Reding in 2010. The motivation for adding it is that some tests fail link-time when cross-compiling. --- Makefile.am | 21 +++-- configure.ac |5 + 2 files changed, 16 insertions(+),

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
Henrik Grindal Bakken writes: > This patch adds --disable-tests to configure. It is based on a patch > posted by Thierry Reding in 2010. The motivation for adding it is that > some tests fail link-time when cross-compiling. This is the alternative approach. I'm not sure what the distinction b

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
Kay Sievers writes: > On Wed, Apr 17, 2013 at 5:49 PM, Henrik Grindal Bakken > wrote: >> This patch adds --disable-tests to configure. It is based on a patch >> posted by Thierry Reding in 2010. The motivation for adding it is >> that some tests fail link-time when cross-compiling. > > Can't

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Kay Sievers
On Wed, Apr 17, 2013 at 5:49 PM, Henrik Grindal Bakken wrote: > This patch adds --disable-tests to configure. It is based on a patch > posted by Thierry Reding in 2010. The motivation for adding it is that > some tests fail link-time when cross-compiling. Can't the tests get its own variables,

[systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
This patch adds --disable-tests to configure. It is based on a patch posted by Thierry Reding in 2010. The motivation for adding it is that some tests fail link-time when cross-compiling. --- Makefile.am | 13 + configure.ac |5 + 2 files changed, 18 insertions(+) diff --