Re: [systemd-devel] [PATCH] cgroups: Cache controller masks and optimize queues.

2013-11-22 Thread David Timothy Strauss
On Sat, Nov 23, 2013 at 7:53 AM, David Timothy Strauss wrote: > My attempts to discuss options and > approaches with you at LinuxCon, on the mailing list, and IRC have > only been marginally productive. Before my commit, we only had a TODO > logged. Actually, I'm being a bit unfair here. Most of

Re: [systemd-devel] [PATCH] cgroups: Cache controller masks and optimize queues.

2013-11-22 Thread David Timothy Strauss
I'm disappointed in your response here. It's not up to your normally high standards of technical discourse and tact on this mailing list. I realize I've stepped on some feet, but there's quite a bit more to this than me getting trigger-happy with a core commit. On Fri, Nov 22, 2013 at 11:43 PM, Le

Re: [systemd-devel] [PATCH] cgroups: Cache controller masks and optimize queues.

2013-11-22 Thread Lennart Poettering
On Tue, 19.11.13 17:12, David Timothy Strauss (da...@davidstrauss.net) wrote: > > I'm pretty confident in the accuracy of the controller mask > aggregation, especially given the new unit test. Here are the main > review questions. Ahum. Please do not just commit stuff like this that is not obvio

Re: [systemd-devel] [PATCH] cgroups: Cache controller masks and optimize queues.

2013-11-18 Thread David Timothy Strauss
I'm pretty confident in the accuracy of the controller mask aggregation, especially given the new unit test. Here are the main review questions. Is it okay to couple realizing the cgroups and applying the attributes the way the patch does? Before, we were often applying the attributes for all of a

[systemd-devel] [PATCH] cgroups: Cache controller masks and optimize queues.

2013-11-18 Thread david
From: David Strauss --- .gitignore | 1 + Makefile.am | 13 +++ src/core/cgroup.c | 94 +++-- src/core/cgroup.h | 2 + src/core/unit.c | 8 +++- src/core/unit.h | 1 + src