Re: [systemd-devel] [PATCH] config_parse_exec_mount_flags: get rid of unnecessary copy

2015-04-23 Thread Lennart Poettering
On Fri, 13.02.15 09:49, Maciej Wereski (m.were...@partner.samsung.com) wrote: Dnia środa, 11 lutego 2015 13:08:26 Lennart Poettering pisze: This optimization is not valid. If 'word' is set to sh, then l will be 2, and strneq(word, shared, 2) is true, but we don't actually want to

Re: [systemd-devel] [PATCH] config_parse_exec_mount_flags: get rid of unnecessary copy

2015-02-13 Thread Maciej Wereski
Dnia środa, 11 lutego 2015 13:08:26 Lennart Poettering pisze: This optimization is not valid. If 'word' is set to sh, then l will be 2, and strneq(word, shared, 2) is true, but we don't actually want to allow such abbreviations! Lennart True, I can use strlen(shared ) then as a n value

Re: [systemd-devel] [PATCH] config_parse_exec_mount_flags: get rid of unnecessary copy

2015-02-11 Thread Lennart Poettering
On Fri, 06.02.15 16:46, Maciej Wereski (m.were...@partner.samsung.com) wrote: --- src/core/load-fragment.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/core/load-fragment.c b/src/core/load-fragment.c index 90bf563..6108d12 100644 ---

[systemd-devel] [PATCH] config_parse_exec_mount_flags: get rid of unnecessary copy

2015-02-06 Thread Maciej Wereski
--- src/core/load-fragment.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/core/load-fragment.c b/src/core/load-fragment.c index 90bf563..6108d12 100644 --- a/src/core/load-fragment.c +++ b/src/core/load-fragment.c @@ -1203,21 +1203,15 @@ int