Re: [systemd-devel] [PATCH] configure.ac: check if AM_PATH_LIBGCRYPT is a defined macro

2013-05-06 Thread Michael Biebl
Say Lennart prepares a new upstream release and forgot to install libgcrypt-devel, then he silently produces a dist tarball which will be broken. I'm not sure I like that behaviour. Michael 2013/5/6 Elia Pinto gitter.spi...@gmail.com: To search the libgcrypt support the developer are advised

Re: [systemd-devel] [PATCH] configure.ac: check if AM_PATH_LIBGCRYPT is a defined macro

2013-05-06 Thread Zbigniew Jędrzejewski-Szmek
On Mon, May 06, 2013 at 07:35:18PM +0200, Michael Biebl wrote: Say Lennart prepares a new upstream release and forgot to install libgcrypt-devel, then he silently produces a dist tarball which will be broken. I'm not sure I like that behaviour. It would be better to fix gcrypt to support

Re: [systemd-devel] [PATCH] configure.ac: check if AM_PATH_LIBGCRYPT is a defined macro

2013-05-06 Thread Lennart Poettering
On Mon, 06.05.13 09:46, Elia Pinto (gitter.spi...@gmail.com) wrote: To search the libgcrypt support the developer are advised to use the automake macro AM_PATH_LIBGCRYPT. But if libgcrypt-devel is not installed the macro does not exist yet and so configure goes wrong. This patch test first

[systemd-devel] [PATCH] configure.ac: check if AM_PATH_LIBGCRYPT is a defined macro

2013-05-06 Thread Elia Pinto
To search the libgcrypt support the developer are advised to use the automake macro AM_PATH_LIBGCRYPT. But if libgcrypt-devel is not installed the macro does not exist yet and so configure goes wrong. This patch test first whether the macro is defined, and if not it set have_lgcrypt to false.