Re: [systemd-devel] [PATCH] core: don't complain if cgroup property is missing

2014-08-15 Thread Umut Tezduyar Lindskog
On Fri, Aug 15, 2014 at 2:45 AM, Lennart Poettering lenn...@poettering.net wrote: On Fri, 15.08.14 02:42, Lennart Poettering (lenn...@poettering.net) wrote: On Tue, 15.07.14 11:53, Umut Tezduyar Lindskog (umut.tezdu...@axis.com) wrote: Looks Ok, but doesn't apply to currently git

Re: [systemd-devel] [PATCH] core: don't complain if cgroup property is missing

2014-08-15 Thread Lennart Poettering
On Fri, 15.08.14 09:12, Umut Tezduyar Lindskog (u...@tezduyar.com) wrote: On Fri, Aug 15, 2014 at 2:45 AM, Lennart Poettering lenn...@poettering.net wrote: On Fri, 15.08.14 02:42, Lennart Poettering (lenn...@poettering.net) wrote: On Tue, 15.07.14 11:53, Umut Tezduyar Lindskog

Re: [systemd-devel] [PATCH] core: don't complain if cgroup property is missing

2014-08-15 Thread Lennart Poettering
On Fri, 15.08.14 11:46, Lennart Poettering (lenn...@poettering.net) wrote: I think there is a misunderstanding. Cgroup properties do not exist if they are turned off. And since your concern is EACCESS, I think a file exists? check inside cg_set_attribute before we call write_string_file

Re: [systemd-devel] [PATCH] core: don't complain if cgroup property is missing

2014-08-14 Thread Lennart Poettering
On Tue, 15.07.14 11:53, Umut Tezduyar Lindskog (umut.tezdu...@axis.com) wrote: Looks Ok, but doesn't apply to currently git anymore... It's really awful though that the kernel returns EACESS on these. I wished it would return ENOTSUP or so! --- src/core/cgroup.c |6 +++--- 1 file

Re: [systemd-devel] [PATCH] core: don't complain if cgroup property is missing

2014-08-14 Thread Lennart Poettering
On Fri, 15.08.14 02:42, Lennart Poettering (lenn...@poettering.net) wrote: On Tue, 15.07.14 11:53, Umut Tezduyar Lindskog (umut.tezdu...@axis.com) wrote: Looks Ok, but doesn't apply to currently git anymore... (In case this wasn't clear, please rebase and I'll commit this. -- Or actually,

[systemd-devel] [PATCH] core: don't complain if cgroup property is missing

2014-07-15 Thread Umut Tezduyar Lindskog
--- src/core/cgroup.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/core/cgroup.c b/src/core/cgroup.c index cd67963..ed5687d 100644 --- a/src/core/cgroup.c +++ b/src/core/cgroup.c @@ -303,12 +303,12 @@ void cgroup_context_apply(CGroupContext *c,