Re: [systemd-devel] [PATCH] fstab-generator: avoid mangling mount source and dest

2012-07-12 Thread Manuel Amador (Rudd-O)
It will also break ZFS legacy mounts. On Mon, 2012-06-04 at 08:04 -0400, Dave Reisner wrote: > On Mon, Jun 04, 2012 at 12:57:47PM +0200, Kay Sievers wrote: > > On Sun, Jun 3, 2012 at 4:18 AM, Dave Reisner wrote: > > > This can invalidate otherwise valid source paths with trailing slashes, > > >

Re: [systemd-devel] [PATCH] fstab-generator: avoid mangling mount source and dest

2012-06-19 Thread Lennart Poettering
On Mon, 04.06.12 09:45, Dave Reisner (d...@falconindy.com) wrote: > Not the most convenient thing to type, but it gets the job done: > > $ systemctl status '\x2esnap.mount' > \x2esnap.mount - /.snap > Loaded: loaded (/etc/fstab) > Active: active (mounted) since Mon, 04 Jun 201

Re: [systemd-devel] [PATCH] fstab-generator: avoid mangling mount source and dest

2012-06-04 Thread Dave Reisner
On Mon, Jun 04, 2012 at 09:45:18AM -0400, Dave Reisner wrote: > On Mon, Jun 04, 2012 at 03:25:29PM +0200, Kay Sievers wrote: > > On Mon, Jun 4, 2012 at 2:04 PM, Dave Reisner wrote: > > > On Mon, Jun 04, 2012 at 12:57:47PM +0200, Kay Sievers wrote: > > >> On Sun, Jun 3, 2012 at 4:18 AM, Dave Reisne

Re: [systemd-devel] [PATCH] fstab-generator: avoid mangling mount source and dest

2012-06-04 Thread Dave Reisner
On Mon, Jun 04, 2012 at 03:25:29PM +0200, Kay Sievers wrote: > On Mon, Jun 4, 2012 at 2:04 PM, Dave Reisner wrote: > > On Mon, Jun 04, 2012 at 12:57:47PM +0200, Kay Sievers wrote: > >> On Sun, Jun 3, 2012 at 4:18 AM, Dave Reisner > >> wrote: > >> > This can invalidate otherwise valid source path

Re: [systemd-devel] [PATCH] fstab-generator: avoid mangling mount source and dest

2012-06-04 Thread Kay Sievers
On Mon, Jun 4, 2012 at 2:04 PM, Dave Reisner wrote: > On Mon, Jun 04, 2012 at 12:57:47PM +0200, Kay Sievers wrote: >> On Sun, Jun 3, 2012 at 4:18 AM, Dave Reisner wrote: >> > This can invalidate otherwise valid source paths with trailing slashes, >> > such as "host:/" in the case of a network mou

Re: [systemd-devel] [PATCH] fstab-generator: avoid mangling mount source and dest

2012-06-04 Thread Dave Reisner
On Mon, Jun 04, 2012 at 12:57:47PM +0200, Kay Sievers wrote: > On Sun, Jun 3, 2012 at 4:18 AM, Dave Reisner wrote: > > This can invalidate otherwise valid source paths with trailing slashes, > > such as "host:/" in the case of a network mount. We don't really have > > any business touching these a

Re: [systemd-devel] [PATCH] fstab-generator: avoid mangling mount source and dest

2012-06-04 Thread Kay Sievers
On Sun, Jun 3, 2012 at 4:18 AM, Dave Reisner wrote: > This can invalidate otherwise valid source paths with trailing slashes, > such as "host:/" in the case of a network mount. We don't really have > any business touching these anyway, since we'll just pass this to > /bin/mount, which sanitizes th

[systemd-devel] [PATCH] fstab-generator: avoid mangling mount source and dest

2012-06-02 Thread Dave Reisner
This can invalidate otherwise valid source paths with trailing slashes, such as "host:/" in the case of a network mount. We don't really have any business touching these anyway, since we'll just pass this to /bin/mount, which sanitizes the paths for us. --- src/fstab-generator/fstab-generator.c |