Re: [systemd-devel] [PATCH] journal-remote-parse: avoid passing null to memchr

2014-04-06 Thread Thomas H.P. Andersen
On Sat, Apr 5, 2014 at 10:08 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Sat, Apr 05, 2014 at 09:09:47PM +0200, Thomas H.P. Andersen wrote: >> static int get_line(RemoteSource *source, char **line, size_t *size) { >> ssize_t n, remain; >> -char *c; >> +char *c = NULL; >>

Re: [systemd-devel] [PATCH] journal-remote-parse: avoid passing null to memchr

2014-04-05 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 05, 2014 at 09:09:47PM +0200, Thomas H.P. Andersen wrote: > static int get_line(RemoteSource *source, char **line, size_t *size) { > ssize_t n, remain; > -char *c; > +char *c = NULL; > char *newbuf = NULL; > size_t newsize = 0; > > @@ -49,7

[systemd-devel] [PATCH] journal-remote-parse: avoid passing null to memchr

2014-04-05 Thread Thomas H.P. Andersen
From: Thomas Hindoe Paaboel Andersen Found with scan-build --- src/journal/journal-remote-parse.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/journal/journal-remote-parse.c b/src/journal/journal-remote-parse.c index 142de0e..239ff38 100644 --- a/src/journal/jou