Re: [systemd-devel] [PATCH] journalctl: verify object size in enumerate_unique

2014-08-26 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Aug 26, 2014 at 09:47:54PM +0200, Lennart Poettering wrote: > On Sat, 23.08.14 22:39, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > We assumed that objects in a unique chain are good enough, > > and only checked object type. But mmap code crashes when some object > > has zer

Re: [systemd-devel] [PATCH] journalctl: verify object size in enumerate_unique

2014-08-26 Thread Lennart Poettering
On Sat, 23.08.14 22:39, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > We assumed that objects in a unique chain are good enough, > and only checked object type. But mmap code crashes when some object > has zero size. This most likely is caused by a corrupted journal > file, but we shoul

[systemd-devel] [PATCH] journalctl: verify object size in enumerate_unique

2014-08-23 Thread Zbigniew Jędrzejewski-Szmek
We assumed that objects in a unique chain are good enough, and only checked object type. But mmap code crashes when some object has zero size. This most likely is caused by a corrupted journal file, but we should fail gracefully. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=758392 https://bug