Re: [systemd-devel] [PATCH] libudev: fix check for too long packet

2015-01-23 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jan 23, 2015 at 05:29:46PM +, Topi Miettinen wrote: On 01/23/15 03:06, Lennart Poettering wrote: On Sun, 18.01.15 23:57, Topi Miettinen (toiwo...@gmail.com) wrote: Don't use recvmsg(2) return value to check for too long packets (it doesn't work) but MSG_TRUNC flag. Why

Re: [systemd-devel] [PATCH] libudev: fix check for too long packet

2015-01-23 Thread Topi Miettinen
On 01/23/15 17:43, Lennart Poettering wrote: On Fri, 23.01.15 17:29, Topi Miettinen (toiwo...@gmail.com) wrote: On 01/23/15 03:06, Lennart Poettering wrote: On Sun, 18.01.15 23:57, Topi Miettinen (toiwo...@gmail.com) wrote: Don't use recvmsg(2) return value to check for too long packets

Re: [systemd-devel] [PATCH] libudev: fix check for too long packet

2015-01-23 Thread Topi Miettinen
On 01/23/15 03:06, Lennart Poettering wrote: On Sun, 18.01.15 23:57, Topi Miettinen (toiwo...@gmail.com) wrote: Don't use recvmsg(2) return value to check for too long packets (it doesn't work) but MSG_TRUNC flag. Why precisely doesn't this work? I mean, it will consider messages that are

Re: [systemd-devel] [PATCH] libudev: fix check for too long packet

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 17:29, Topi Miettinen (toiwo...@gmail.com) wrote: On 01/23/15 03:06, Lennart Poettering wrote: On Sun, 18.01.15 23:57, Topi Miettinen (toiwo...@gmail.com) wrote: Don't use recvmsg(2) return value to check for too long packets (it doesn't work) but MSG_TRUNC flag.

Re: [systemd-devel] [PATCH] libudev: fix check for too long packet

2015-01-22 Thread Lennart Poettering
On Sun, 18.01.15 23:57, Topi Miettinen (toiwo...@gmail.com) wrote: Don't use recvmsg(2) return value to check for too long packets (it doesn't work) but MSG_TRUNC flag. Why precisely doesn't this work? I mean, it will consider messages that are exactly as large as the buffer as too long, but

[systemd-devel] [PATCH] libudev: fix check for too long packet

2015-01-18 Thread Topi Miettinen
Don't use recvmsg(2) return value to check for too long packets (it doesn't work) but MSG_TRUNC flag. --- src/libudev/libudev-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libudev/libudev-monitor.c b/src/libudev/libudev-monitor.c index 484fefe..d8e551b 100644