Re: [systemd-devel] [PATCH] networkd: don't touch global forwarding setting

2015-05-15 Thread Lennart Poettering
On Wed, 13.05.15 19:19, Lennart Poettering (lenn...@poettering.net) wrote: > On Sun, 10.05.15 20:52, Benedikt Morbach (benedikt.morb...@googlemail.com) > wrote: > > > This reverts commit 43c6d5abacaebf813845934ec8d5e5ee3c431854 > > (and a small part of 4046d8361c55c80ab8577aea52523b9e6eab0d0c) >

Re: [systemd-devel] [PATCH] networkd: don't touch global forwarding setting

2015-05-13 Thread Lennart Poettering
On Sun, 10.05.15 20:52, Benedikt Morbach (benedikt.morb...@googlemail.com) wrote: > This reverts commit 43c6d5abacaebf813845934ec8d5e5ee3c431854 > (and a small part of 4046d8361c55c80ab8577aea52523b9e6eab0d0c) > > It turns out we don't actually need to set the global ip_forward setting. > The on

Re: [systemd-devel] [PATCH] networkd: don't touch global forwarding setting

2015-05-10 Thread systemd github import bot
Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-

[systemd-devel] [PATCH] networkd: don't touch global forwarding setting

2015-05-10 Thread Benedikt Morbach
This reverts commit 43c6d5abacaebf813845934ec8d5e5ee3c431854 (and a small part of 4046d8361c55c80ab8577aea52523b9e6eab0d0c) It turns out we don't actually need to set the global ip_forward setting. The only relevant setting is the one on each interface. What the global toggle actually does is swi

Re: [systemd-devel] [PATCH] networkd: don't touch global forwarding setting

2015-04-28 Thread Lennart Poettering
On Tue, 28.04.15 19:51, Benedikt Morbach (benedikt.morb...@googlemail.com) wrote: > On Tue, Apr 28, 2015 at 7:36 PM, Lennart Poettering > wrote: > > If eth1 shows up first, then it will be configured, and thus the local > > ip forwaring turned off, the global is left untouched. Since the other >

Re: [systemd-devel] [PATCH] networkd: don't touch global forwarding setting

2015-04-28 Thread Benedikt Morbach
On Tue, Apr 28, 2015 at 7:36 PM, Lennart Poettering wrote: > If eth1 shows up first, then it will be configured, and thus the local > ip forwaring turned off, the global is left untouched. Since the other > interface hasn't shown up yet/has not been configured the global > setting doesn't matter f

Re: [systemd-devel] [PATCH] networkd: don't touch global forwarding setting

2015-04-28 Thread Lennart Poettering
On Tue, 28.04.15 18:55, Benedikt Morbach (benedikt.morb...@googlemail.com) wrote: > this inevitably leads to race conditions and also means that IPForward=yes on > one interface is equivalent to setting it on _every_ interface. > (except when it isn't, see below) > > Suppose you have two network

[systemd-devel] [PATCH] networkd: don't touch global forwarding setting

2015-04-28 Thread Benedikt Morbach
this inevitably leads to race conditions and also means that IPForward=yes on one interface is equivalent to setting it on _every_ interface. (except when it isn't, see below) Suppose you have two networks * /etc/systemd/network/eth0.network [Match] Name=eth0 [Network] Address=1