Re: [systemd-devel] [PATCH] path_is_mount_point: handle false positive on some fs

2015-03-12 Thread Lennart Poettering
On Wed, 11.03.15 08:12, Didier Roche (didro...@ubuntu.com) wrote: > Le 10/03/2015 18:54, Lennart Poettering a écrit : > >On Tue, 10.03.15 18:01, Didier Roche (didro...@ubuntu.com) wrote: > > > >>The context is bug > >>https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1411140, where > >>system

Re: [systemd-devel] [PATCH] path_is_mount_point: handle false positive on some fs

2015-03-12 Thread Didier Roche
Le 10/03/2015 16:53, Lennart Poettering a écrit : On Mon, 09.03.15 11:27, Didier Roche (didro...@ubuntu.com) wrote: However, some file systems (seems overlayfs at least) would report a major(st_dev) as 0 on directories and not on files. The current path_is_mount_point() fallback logic would thu

Re: [systemd-devel] [PATCH] path_is_mount_point: handle false positive on some fs

2015-03-11 Thread Karel Zak
On Tue, Mar 10, 2015 at 04:53:38PM +0100, Lennart Poettering wrote: > Note that the st_dev thing is the traditional way to detect whether > one crosses a file system boundary. It's used for this by tools like > cp, find, We slightly enhance this by using name_to_handle_at(), > so that we can a

Re: [systemd-devel] [PATCH] path_is_mount_point: handle false positive on some fs

2015-03-11 Thread Didier Roche
Le 10/03/2015 18:54, Lennart Poettering a écrit : On Tue, 10.03.15 18:01, Didier Roche (didro...@ubuntu.com) wrote: The context is bug https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1411140, where systemd-machine-id-commit unit is entering in failed state (the binary handles gracefully

Re: [systemd-devel] [PATCH] path_is_mount_point: handle false positive on some fs

2015-03-10 Thread Lennart Poettering
On Tue, 10.03.15 18:01, Didier Roche (didro...@ubuntu.com) wrote: > The context is bug > https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1411140, where > systemd-machine-id-commit unit is entering in failed state (the binary > handles gracefully the fact that it can't unmount the file) on a

Re: [systemd-devel] [PATCH] path_is_mount_point: handle false positive on some fs

2015-03-10 Thread Lennart Poettering
On Mon, 09.03.15 11:27, Didier Roche (didro...@ubuntu.com) wrote: > However, some file systems (seems overlayfs at least) would report a > major(st_dev) as 0 on directories and not on files. The current > path_is_mount_point() fallback logic would thus reports that every files is > a mount point.

Re: [systemd-devel] [PATCH] path_is_mount_point: handle false positive on some fs

2015-03-10 Thread Karel Zak
On Mon, Mar 09, 2015 at 11:27:09AM +0100, Didier Roche wrote: > Also we could on the longer term maybe getting the whole path_is_mount_point() > logic into libmount from util-linux, using mnt_get_mountpoint() (but this > one only use st_dev comparison presently)? mnt_table_find_mountpoint() ht

[systemd-devel] [PATCH] path_is_mount_point: handle false positive on some fs

2015-03-09 Thread Didier Roche
Hey, path_is_mount_point() can report some false positive that a file is a mount point on some file systems (like overlayfs). The function tries to call name_to_handle_at(), if this one isn't supported by the file system, then a fallback using stat() is triggered on the entity (which can be