Re: [systemd-devel] [PATCH] sd-bus: fix memory leak in test-bus-chat

2015-05-14 Thread Lennart Poettering
On Sat, 09.05.15 22:14, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: > Building with address sanitizer enabled on GCC 5.1.x a memory leak > is reported because we never close the bus, fix it by using > cleanup variable attribute. Thanks! Applied! > --- > src/libsystemd/sd-bus/test-bus-c

Re: [systemd-devel] [PATCH] sd-bus: fix memory leak in test-bus-chat

2015-05-13 Thread Cristian Rodríguez
On Wed, May 13, 2015 at 8:01 AM, Daniel Mack wrote: > We should still keep this flush, right? > >> -sd_bus_unref(bus); >> } >> The cleanup function already does : static inline void sd_bus_close_unrefp(sd_bus **bus) { if (*bus) { sd_bus_flush(*bus)

Re: [systemd-devel] [PATCH] sd-bus: fix memory leak in test-bus-chat

2015-05-13 Thread Daniel Mack
On 05/10/2015 03:14 AM, Cristian Rodríguez wrote: > Building with address sanitizer enabled on GCC 5.1.x a memory leak > is reported because we never close the bus, fix it by using > cleanup variable attribute. > --- > src/libsystemd/sd-bus/test-bus-chat.c | 4 +--- > 1 file changed, 1 insertion(+

Re: [systemd-devel] [PATCH] sd-bus: fix memory leak in test-bus-chat

2015-05-09 Thread systemd github import bot
Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel

[systemd-devel] [PATCH] sd-bus: fix memory leak in test-bus-chat

2015-05-09 Thread Cristian Rodríguez
Building with address sanitizer enabled on GCC 5.1.x a memory leak is reported because we never close the bus, fix it by using cleanup variable attribute. --- src/libsystemd/sd-bus/test-bus-chat.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/libsystemd/sd-bus/test-bus