[systemd-devel] [PATCH] sd-dhcp-client: log positive error number

2014-04-27 Thread Umut Tezduyar Lindskog
Log error no for such client_stop(client, DHCP_EVENT_STOP) --- src/libsystemd-network/sd-dhcp-client.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/libsystemd-network/sd-dhcp-client.c b/src/libsystemd-network/sd-dhcp-client.c index 854c671..f2266e0

Re: [systemd-devel] [PATCH] sd-dhcp-client: log positive error number

2014-04-27 Thread Tom Gundersen
Applied. Thanks! On Sun, Apr 27, 2014 at 10:01 PM, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: Log error no for such client_stop(client, DHCP_EVENT_STOP) --- src/libsystemd-network/sd-dhcp-client.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git

Re: [systemd-devel] [PATCH] sd-dhcp-client: log positive error number

2014-04-26 Thread Tom Gundersen
On Sat, Apr 26, 2014 at 7:18 AM, Umut Tezduyar Lindskog u...@tezduyar.com wrote: On Sat, Apr 26, 2014 at 12:36 AM, Tom Gundersen t...@jklm.no wrote: On Sun, Apr 13, 2014 at 12:52 PM, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: Log error no for such client_stop(client, DHCP_EVENT_STOP)

Re: [systemd-devel] [PATCH] sd-dhcp-client: log positive error number

2014-04-25 Thread Tom Gundersen
On Sun, Apr 13, 2014 at 12:52 PM, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: Log error no for such client_stop(client, DHCP_EVENT_STOP) --- src/libsystemd-network/sd-dhcp-client.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [systemd-devel] [PATCH] sd-dhcp-client: log positive error number

2014-04-25 Thread Umut Tezduyar Lindskog
On Sat, Apr 26, 2014 at 12:36 AM, Tom Gundersen t...@jklm.no wrote: On Sun, Apr 13, 2014 at 12:52 PM, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: Log error no for such client_stop(client, DHCP_EVENT_STOP) --- src/libsystemd-network/sd-dhcp-client.c |5 - 1 file changed, 4

[systemd-devel] [PATCH] sd-dhcp-client: log positive error number

2014-04-13 Thread Umut Tezduyar Lindskog
Log error no for such client_stop(client, DHCP_EVENT_STOP) --- src/libsystemd-network/sd-dhcp-client.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/libsystemd-network/sd-dhcp-client.c b/src/libsystemd-network/sd-dhcp-client.c index 4892203..9715953 100644 ---

Re: [systemd-devel] [PATCH] sd-dhcp-client: log positive error number

2014-04-13 Thread Tom Gundersen
Hm, why? Are not error messages more useful? On 13 Apr 2014 12:53, Umut Tezduyar Lindskog umut.tezdu...@axis.com wrote: Log error no for such client_stop(client, DHCP_EVENT_STOP) --- src/libsystemd-network/sd-dhcp-client.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [systemd-devel] [PATCH] sd-dhcp-client: log positive error number

2014-04-13 Thread Umut Tezduyar Lindskog
On Sun, Apr 13, 2014 at 1:16 PM, Tom Gundersen t...@jklm.no wrote: Hm, why? Are not error messages more useful? What is going to be the mapping for DHCP_EVENT_STOP? log_dhcp_client(client, STOPPED: %s, strerror(-DHCP_EVENT_STOP)); On 13 Apr 2014 12:53, Umut Tezduyar Lindskog

Re: [systemd-devel] [PATCH] sd-dhcp-client: log positive error number

2014-04-13 Thread Tom Gundersen
On Sun, Apr 13, 2014 at 2:11 PM, Umut Tezduyar Lindskog u...@tezduyar.com wrote: On Sun, Apr 13, 2014 at 1:16 PM, Tom Gundersen t...@jklm.no wrote: Hm, why? Are not error messages more useful? What is going to be the mapping for DHCP_EVENT_STOP? log_dhcp_client(client, STOPPED: %s,