Re: [systemd-devel] [PATCH] shared/util.h: portable sizeof(long) == sizeof(int) test

2014-09-22 Thread David Herrmann
Hi On Fri, Sep 19, 2014 at 10:56 PM, Emil Renner Berthing syst...@esmil.dk wrote: On 19 September 2014 22:19, David Herrmann dh.herrm...@gmail.com wrote: On Fri, Sep 19, 2014 at 8:26 PM, Emil Renner Berthing syst...@esmil.dk wrote: Don't rely on __WORDSIZE, but just standard LONG_MAX and

[systemd-devel] [PATCH] shared/util.h: portable sizeof(long) == sizeof(int) test

2014-09-19 Thread Emil Renner Berthing
Don't rely on __WORDSIZE, but just standard LONG_MAX and INT_MAX from limits.h. --- src/shared/util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/util.h b/src/shared/util.h index 08d556f..00068c6 100644 --- a/src/shared/util.h +++ b/src/shared/util.h @@ -205,7

Re: [systemd-devel] [PATCH] shared/util.h: portable sizeof(long) == sizeof(int) test

2014-09-19 Thread David Herrmann
Hi On Fri, Sep 19, 2014 at 8:26 PM, Emil Renner Berthing syst...@esmil.dk wrote: Don't rely on __WORDSIZE, but just standard LONG_MAX and INT_MAX from limits.h. Why? The commit message lacks any explanation of that change. Thanks David --- src/shared/util.h | 2 +- 1 file changed, 1

Re: [systemd-devel] [PATCH] shared/util.h: portable sizeof(long) == sizeof(int) test

2014-09-19 Thread Emil Renner Berthing
On 19 September 2014 22:19, David Herrmann dh.herrm...@gmail.com wrote: On Fri, Sep 19, 2014 at 8:26 PM, Emil Renner Berthing syst...@esmil.dk wrote: Don't rely on __WORDSIZE, but just standard LONG_MAX and INT_MAX from limits.h. Why? The commit message lacks any explanation of that change.