Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-24 Thread Karel Zak
On Fri, Oct 03, 2014 at 07:16:55AM +0200, Jan Synacek wrote: Karel Zak k...@redhat.com writes: Karel, any chance you can add a -o option to swapon? No problem, added to TODO. I'll implement it next week. Implemented, it's in util-linux git tree, will be in v2.26. Would you please let me

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-21 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Mon, 20.10.14 11:08, Karel Zak (k...@redhat.com) wrote: On Fri, Oct 03, 2014 at 07:16:55AM +0200, Jan Synacek wrote: Karel Zak k...@redhat.com writes: Karel, any chance you can add a -o option to swapon? No problem, added to

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-20 Thread Lennart Poettering
On Mon, 20.10.14 11:08, Karel Zak (k...@redhat.com) wrote: On Fri, Oct 03, 2014 at 07:16:55AM +0200, Jan Synacek wrote: Karel Zak k...@redhat.com writes: Karel, any chance you can add a -o option to swapon? No problem, added to TODO. I'll implement it next week. Implemented, it's

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-02 Thread Lennart Poettering
On Thu, 25.09.14 09:54, Jan Synacek (jsyna...@redhat.com) wrote: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl writes: On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: Process possible discard values from /etc/fstab. Hm, wouldn't it be enough to simply pass through the options

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-02 Thread Karel Zak
On Thu, Oct 02, 2014 at 03:32:54PM +0200, Lennart Poettering wrote: On Thu, 25.09.14 09:54, Jan Synacek (jsyna...@redhat.com) wrote: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl writes: On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: Process possible discard values from

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-02 Thread Jan Synacek
Karel Zak k...@redhat.com writes: On Thu, Oct 02, 2014 at 03:32:54PM +0200, Lennart Poettering wrote: On Thu, 25.09.14 09:54, Jan Synacek (jsyna...@redhat.com) wrote: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl writes: On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote:

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-01 Thread Karel Zak
On Mon, Sep 29, 2014 at 06:52:12PM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Sep 29, 2014 at 08:35:04PM +0400, Andrei Borzenkov wrote: В Mon, 29 Sep 2014 17:16:25 +0200 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl пишет: The problem with reading but back discards settings

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-30 Thread Jan Synacek
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl writes: I pushed your patch with some significant changes, and some follow-up cleanups. Please check that things work for you. The problem with reading but back discards settings remains. Zbyszek It works for me, thanks! -- Jan Synacek

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-29 Thread Jan Synacek
Jan Synacek jsyna...@redhat.com writes: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl writes: On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: Process possible discard values from /etc/fstab. Hm, wouldn't it be enough to simply pass through the options like with mounts, using the

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-29 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Sep 29, 2014 at 01:23:30PM +0200, Jan Synacek wrote: Jan Synacek jsyna...@redhat.com writes: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl writes: On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: Process possible discard values from /etc/fstab. Hm, wouldn't it be

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-29 Thread Andrei Borzenkov
В Mon, 29 Sep 2014 17:16:25 +0200 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl пишет: The problem with reading but back discards settings remains. Seems like the most natural solution is to extend /proc/swaps. The only place where these flags are printed right now is in dmesg during

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-29 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Sep 29, 2014 at 08:35:04PM +0400, Andrei Borzenkov wrote: В Mon, 29 Sep 2014 17:16:25 +0200 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl пишет: The problem with reading but back discards settings remains. Seems like the most natural solution is to extend /proc/swaps. The

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-29 Thread Jan Synacek
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl writes: On Mon, Sep 29, 2014 at 01:23:30PM +0200, Jan Synacek wrote: Ping, could anybody comment, please? C'mon, it's been four days, two of that being the weekend. Sorry for that, it felt like way over a week already... -- Jan Synacek Software

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-25 Thread Jan Synacek
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl writes: On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: Process possible discard values from /etc/fstab. Hm, wouldn't it be enough to simply pass through the options like with mounts, using the Options= option? This might be less work

[systemd-devel] [PATCH] swap: introduce Discard property

2014-09-24 Thread Jan Synacek
Process possible discard values from /etc/fstab. --- man/systemd.swap.xml | 14 + src/core/execute.c| 25 src/core/execute.h| 1 + src/core/load-fragment-gperf.gperf.m4 | 1 + src/core/swap.c

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-24 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: Process possible discard values from /etc/fstab. Hm, wouldn't it be enough to simply pass through the options like with mounts, using the Options= option? This might be less work and be more flexible. Zbyszek ---