Re: [systemd-devel] [PATCH] systemd crashes if locale.conf contains invalid utf8 string

2014-02-08 Thread Goffredo Baroncelli
On 02/08/2014 07:15 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Feb 06, 2014 at 07:09:59PM +0100, Goffredo Baroncelli wrote: [...] > Applied. Great ! [...] > Zbyszek > -- gpg @keyserver.linux.it: Goffredo Baroncelli (kreijackATinwind.it> Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0E

Re: [systemd-devel] [PATCH] systemd crashes if locale.conf contains invalid utf8 string

2014-02-08 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Feb 06, 2014 at 07:09:59PM +0100, Goffredo Baroncelli wrote: > In the parse_env_file_push() and load_env_file_push() functions, there > are two assert() call to check if the key or value parameters are utf8 valid. > > If the strings aren't utf8 valid, assert does abort. > > These function

Re: [systemd-devel] [PATCH] systemd crashes if locale.conf contains invalid utf8 string

2014-02-06 Thread David Timothy Strauss
+1 on no crashing with invalid user input ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] systemd crashes if locale.conf contains invalid utf8 string

2014-02-06 Thread Goffredo Baroncelli
In the parse_env_file_push() and load_env_file_push() functions, there are two assert() call to check if the key or value parameters are utf8 valid. If the strings aren't utf8 valid, assert does abort. These function are used early by systemd to parse some files. For example '/etc/locale.conf'.