Re: [systemd-devel] [PATCH] sysv-generator: Skip init scripts for existing native services

2015-02-06 Thread Colin Guthrie
Michael Biebl wrote on 04/02/15 19:59: 2015-02-04 13:42 GMT+01:00 Lennart Poettering lenn...@poettering.net: Hello all, a little while ago, Jon Severinsson wrote a sysv generator optimization to not go through all the parsing of init.d scripts and creation of units if there already is a

Re: [systemd-devel] [PATCH] sysv-generator: Skip init scripts for existing native services

2015-02-05 Thread Martin Pitt
Jóhann B. Guðmundsson [2015-02-04 22:36 +]: I expect Debian to do the same sane thing as everyone else did back in the day and strike out that components will be allowed to migrate to units [...] Then next thing the Debian community will realize is that once maintainers have made the

[systemd-devel] [PATCH] sysv-generator: Skip init scripts for existing native services

2015-02-04 Thread Martin Pitt
Hello all, a little while ago, Jon Severinsson wrote a sysv generator optimization to not go through all the parsing of init.d scripts and creation of units if there already is a native unit for that name. As they are put into generator.late they would be ignored anyway. This is particularly

Re: [systemd-devel] [PATCH] sysv-generator: Skip init scripts for existing native services

2015-02-04 Thread Michael Biebl
2015-02-04 13:42 GMT+01:00 Lennart Poettering lenn...@poettering.net: Hello all, a little while ago, Jon Severinsson wrote a sysv generator optimization to not go through all the parsing of init.d scripts and creation of units if there already is a native unit for that name. As they are put

Re: [systemd-devel] [PATCH] sysv-generator: Skip init scripts for existing native services

2015-02-04 Thread Uoti Urpala
On Wed, 2015-02-04 at 15:06 +0100, Martin Pitt wrote: Lennart Poettering [2015-02-04 13:42 +0100]: Well, but their enablement status so far is not ignored. i.e. if you drop in a unit file, as well as a sysv script, and the latter is enabled, but the former not, then systemd currently reads

Re: [systemd-devel] [PATCH] sysv-generator: Skip init scripts for existing native services

2015-02-04 Thread Lennart Poettering
On Wed, 04.02.15 21:26, Uoti Urpala (uoti.urp...@pp1.inet.fi) wrote: On Wed, 2015-02-04 at 15:06 +0100, Martin Pitt wrote: Lennart Poettering [2015-02-04 13:42 +0100]: Well, but their enablement status so far is not ignored. i.e. if you drop in a unit file, as well as a sysv script, and

Re: [systemd-devel] [PATCH] sysv-generator: Skip init scripts for existing native services

2015-02-04 Thread Uoti Urpala
On Wed, 2015-02-04 at 22:02 +0100, Lennart Poettering wrote: On Wed, 04.02.15 21:26, Uoti Urpala (uoti.urp...@pp1.inet.fi) wrote: Isn't this change also relevant to the creation of .wants symlinks, and avoiding generating .wants links from the wrong targets? As in, the case where you

Re: [systemd-devel] [PATCH] sysv-generator: Skip init scripts for existing native services

2015-02-04 Thread Lennart Poettering
On Wed, 04.02.15 15:06, Martin Pitt (martin.p...@ubuntu.com) wrote: Hey, Lennart Poettering [2015-02-04 13:42 +0100]: Well, but their enablement status so far is not ignored. i.e. if you drop in a unit file, as well as a sysv script, and the latter is enabled, but the former not, then

Re: [systemd-devel] [PATCH] sysv-generator: Skip init scripts for existing native services

2015-02-04 Thread Lennart Poettering
On Wed, 04.02.15 22:01, Lennart Poettering (lenn...@poettering.net) wrote: On Wed, 04.02.15 15:06, Martin Pitt (martin.p...@ubuntu.com) wrote: Hey, Lennart Poettering [2015-02-04 13:42 +0100]: Well, but their enablement status so far is not ignored. i.e. if you drop in a unit

Re: [systemd-devel] [PATCH] sysv-generator: Skip init scripts for existing native services

2015-02-04 Thread Jóhann B. Guðmundsson
On 02/04/2015 09:20 PM, Lennart Poettering wrote: On Wed, 04.02.15 22:01, Lennart Poettering (lenn...@poettering.net) wrote: On Wed, 04.02.15 15:06, Martin Pitt (martin.p...@ubuntu.com) wrote: Hey, Lennart Poettering [2015-02-04 13:42 +0100]: Well, but their enablement status so far

Re: [systemd-devel] [PATCH] sysv-generator: Skip init scripts for existing native services

2015-02-04 Thread Lennart Poettering
On Wed, 04.02.15 10:08, Martin Pitt (martin.p...@ubuntu.com) wrote: Hello all, a little while ago, Jon Severinsson wrote a sysv generator optimization to not go through all the parsing of init.d scripts and creation of units if there already is a native unit for that name. As they are put

Re: [systemd-devel] [PATCH] sysv-generator: Skip init scripts for existing native services

2015-02-04 Thread Martin Pitt
Hey, Lennart Poettering [2015-02-04 13:42 +0100]: Well, but their enablement status so far is not ignored. i.e. if you drop in a unit file, as well as a sysv script, and the latter is enabled, but the former not, then systemd currently reads that so that the sysv one is overriden by the