Re: [systemd-devel] [PATCH] sysv-generator: handle Provides: for non-virtual facility names

2015-01-07 Thread Michael Biebl
Thanks for the review. Pushed as b7e7184634d573fb73143210962acce205f37f61 2015-01-06 0:25 GMT+01:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl: On Tue, Jan 06, 2015 at 12:01:35AM +0100, Michael Biebl wrote: Hi, 2015-01-05 14:35 GMT+01:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl:

[systemd-devel] [PATCH] sysv-generator: handle Provides: for non-virtual facility names

2015-01-05 Thread Michael Biebl
See attached patch. The commit message reads: The list of provided facility names as specified via Provides: in the LSB header was originally implemented by adding those facilities to the Names= property via unit_add_name(). In commit 95ed3294c632f5606327149f10cef1eb34422862 the internal SysV

Re: [systemd-devel] [PATCH] sysv-generator: handle Provides: for non-virtual facility names

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 05, 2015 at 10:30:11AM +0100, Michael Biebl wrote: See attached patch. The commit message reads: The list of provided facility names as specified via Provides: in the LSB header was originally implemented by adding those facilities to the Names= property via unit_add_name().

Re: [systemd-devel] [PATCH] sysv-generator: handle Provides: for non-virtual facility names

2015-01-05 Thread Michael Biebl
Hi, 2015-01-05 14:35 GMT+01:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl: On Mon, Jan 05, 2015 at 10:30:11AM +0100, Michael Biebl wrote: +link = strjoin(arg_dest, /, alias, NULL); +if (!link) +return log_oom(); path_join()? I borrowed from the existing

Re: [systemd-devel] [PATCH] sysv-generator: handle Provides: for non-virtual facility names

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 06, 2015 at 12:01:35AM +0100, Michael Biebl wrote: Hi, 2015-01-05 14:35 GMT+01:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl: On Mon, Jan 05, 2015 at 10:30:11AM +0100, Michael Biebl wrote: +link = strjoin(arg_dest, /, alias, NULL); +if (!link) +