Re: [systemd-devel] [PATCH] timedatectl: check for getenv("TZDIR")

2015-04-02 Thread Lennart Poettering
On Fri, 27.03.15 09:46, Shawn Landden (sh...@churchofgit.com) wrote: > I liked having the DST information. It is a pity glibc doesn't export > this information. > > If TZDIR is set, glibc will look there rather than /usr/share/zoneinfo. > See tzset(3). What's the rationale for this? Why would we

[systemd-devel] [PATCH] timedatectl: check for getenv("TZDIR")

2015-03-27 Thread Shawn Landden
I liked having the DST information. It is a pity glibc doesn't export this information. If TZDIR is set, glibc will look there rather than /usr/share/zoneinfo. See tzset(3). --- src/timedate/timedatectl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/timedate/time

Re: [systemd-devel] [PATCH] timedatectl: check for getenv("TZDIR")

2015-03-27 Thread Tom Gundersen
Hi Shawn, Could you redo the commit message to explain what's going on here? I.e., what ends up being 'wrong' when we ignore TZDIR? Maybe also make this clearer in the warning. -t On Tue, Mar 24, 2015 at 8:02 PM, Shawn Landden wrote: > I liked having the DST information. It is a pity glibc does

[systemd-devel] [PATCH] timedatectl: check for getenv("TZDIR")

2015-03-24 Thread Shawn Landden
I liked having the DST information. It is a pity glibc doesn't export this information. v3 --- src/timedate/timedatectl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/timedate/timedatectl.c b/src/timedate/timedatectl.c index ab5c8a1..d529a0a 100644 --- a/src/timedate/timedatectl.c

[systemd-devel] [PATCH] timedatectl: check for getenv("TZDIR")

2015-03-24 Thread Shawn Landden
I liked having the DST information. It is a pity glibc doesn't export this information. avoid calling gmtime_r() and localtime_r() twice deduplicate some strings v2 --- src/timedate/timedatectl.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/src/ti