Re: [systemd-devel] [PATCH] timedated: gather timezone from /etc/localtime sym target

2012-08-14 Thread Frederic Crozat
Le mercredi 08 août 2012 à 18:51 +0200, Lennart Poettering a écrit : On Tue, 07.08.12 00:31, Shawn Landen (shawnland...@gmail.com) wrote: keep other method for now, consider dropping later. Supporting relative links here could be problematic as timezones in /usr/share/zoneinfo are

Re: [systemd-devel] [PATCH] timedated: gather timezone from /etc/localtime sym target

2012-08-14 Thread Frederic Crozat
Le mardi 14 août 2012 à 11:20 +0200, Frederic Crozat a écrit : Le mercredi 08 août 2012 à 18:51 +0200, Lennart Poettering a écrit : On Tue, 07.08.12 00:31, Shawn Landen (shawnland...@gmail.com) wrote: keep other method for now, consider dropping later. Supporting relative links

Re: [systemd-devel] [PATCH] timedated: gather timezone from /etc/localtime sym target

2012-08-14 Thread shawn
On Tue, 2012-08-14 at 11:20 +0200, Frederic Crozat wrote: Le mercredi 08 août 2012 à 18:51 +0200, Lennart Poettering a écrit : On Tue, 07.08.12 00:31, Shawn Landen (shawnland...@gmail.com) wrote: keep other method for now, consider dropping later. Supporting relative links here

Re: [systemd-devel] [PATCH] timedated: gather timezone from /etc/localtime sym target

2012-08-10 Thread Koen Kooi
Op 8 aug. 2012, om 18:51 heeft Lennart Poettering lenn...@poettering.net het volgende geschreven: On Tue, 07.08.12 00:31, Shawn Landen (shawnland...@gmail.com) wrote: keep other method for now, consider dropping later. Supporting relative links here could be problematic as timezones in

Re: [systemd-devel] [PATCH] timedated: gather timezone from /etc/localtime sym target

2012-08-08 Thread Lennart Poettering
On Tue, 07.08.12 00:31, Shawn Landen (shawnland...@gmail.com) wrote: keep other method for now, consider dropping later. Supporting relative links here could be problematic as timezones in /usr/share/zoneinfo are often themselves symlinks (and symlinks to symlinks), so this implamentation

Re: [systemd-devel] [PATCH] timedated: gather timezone from /etc/localtime sym target

2012-08-08 Thread Kay Sievers
On Wed, Aug 8, 2012 at 6:51 PM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 07.08.12 00:31, Shawn Landen (shawnland...@gmail.com) wrote: keep other method for now, consider dropping later. Supporting relative links here could be problematic as timezones in /usr/share/zoneinfo

Re: [systemd-devel] [PATCH] timedated: gather timezone from /etc/localtime sym target

2012-08-08 Thread Tom Gundersen
On Wed, Aug 8, 2012 at 6:51 PM, Lennart Poettering lenn...@poettering.net wrote: So, dunno, I think this is something to think about first, discuss the pros and cons. I see that just having this as symlink is much simpler, no doubt, but does it have more benefits? And possibly more

[systemd-devel] [PATCH] timedated: gather timezone from /etc/localtime sym target

2012-08-08 Thread Shawn Landen
keep other method for now, consider dropping later. Supporting relative links here could be problematic as timezones in /usr/share/zoneinfo are often themselves symlinks (and symlinks to symlinks), so this implamentation only only support absolute links. v2 - Add ZONEINFO_PATH - Restructured

Re: [systemd-devel] [PATCH] timedated: gather timezone from /etc/localtime sym target

2012-08-08 Thread Lennart Poettering
On Wed, 08.08.12 19:29, Shawn Landen (shawnland...@gmail.com) wrote: keep other method for now, consider dropping later. Supporting relative links here could be problematic as timezones in /usr/share/zoneinfo are often themselves symlinks (and symlinks to symlinks), so this implamentation

[systemd-devel] [PATCH] timedated: gather timezone from /etc/localtime sym target

2012-08-08 Thread shawnlandden
From: Shawn Landen shawnland...@gmail.com keep other method for now, consider dropping later. Supporting relative links here could be problematic as timezones in /usr/share/zoneinfo are often themselves symlinks (and symlinks to symlinks), so this implamentation only only support absolute links.

Re: [systemd-devel] [PATCH] timedated: gather timezone from /etc/localtime sym target

2012-08-08 Thread shawn
On Wed, 2012-08-08 at 22:56 +0200, Lennart Poettering wrote: static int read_data(void) { int r; +struct stat st; free_data(); +r = lstat(/etc/localtime, st); +if (r 0) { +log_warning(lstat() of %s failed: %m,

[systemd-devel] [PATCH] timedated: gather timezone from /etc/localtime sym target

2012-08-06 Thread Shawn Landen
keep other method for now, consider dropping later. Supporting relative links here could be problematic as timezones in /usr/share/zoneinfo are often themselves symlinks (and symlinks to symlinks), so this implamentation only only support absolute links. --- src/timedate/timedated.c | 28