[systemd-devel] [PATCH] tree-wide: Introduce a dup_cloexec inline helper

2015-04-22 Thread Cristian Rodríguez
- Nicer easier to remember than fcntl(fd, F_DUPFD_CLOEXEC, 3) - Update CODING_STYLE - Use it tree-wide --- CODING_STYLE | 6 +++--- src/import/curl-util.c | 2 +- src/import/importd.c | 4 ++-- src/journal/cat.c| 2 +-

Re: [systemd-devel] [PATCH] tree-wide: Introduce a dup_cloexec inline helper

2015-04-22 Thread systemd github import bot
Patchset imported to github. Pull request: https://github.com/systemd-devs/systemd/compare/master...systemd-mailing-devs:1429730951-13156-1-git-send-email-crrodriguez%40opensuse.org -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel

Re: [systemd-devel] [PATCH] tree-wide: Introduce a dup_cloexec inline helper

2015-04-22 Thread Lennart Poettering
On Wed, 22.04.15 16:29, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: - Nicer easier to remember than fcntl(fd, F_DUPFD_CLOEXEC, 3) - Update CODING_STYLE - Use it tree-wide I am not convinced this is a good idea like this. Our own functions tend to return proper negative error codes.