[systemd-devel] [PATCH] udev: Remove hard-coded string offsets when parsing kernel command line.

2014-11-05 Thread Richard W.M. Jones
--- src/udev/udevd.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/udev/udevd.c b/src/udev/udevd.c index 193702c..340812b 100644 --- a/src/udev/udevd.c +++ b/src/udev/udevd.c @@ -968,6 +968,7 @@ static void kernel_cmdline_options(struct udev

[systemd-devel] [PATCH] udev: Remove hard-coded string offsets when parsing kernel

2014-11-05 Thread Richard W.M. Jones
This avoids the hard-coded string offsets by using strlen. It's a bit of a strange coding style. Mainly I was interested to see if gcc could optimize this, and (gcc-4.9.2 / x86-64 / -O2) it did - all calls to strlen are removed from the assembly and replaced by constants. When I compile systemd

Re: [systemd-devel] [PATCH] udev: Remove hard-coded string offsets when parsing kernel command line.

2014-11-05 Thread David Herrmann
Hi On Wed, Nov 5, 2014 at 10:16 AM, Richard W.M. Jones rjo...@redhat.com wrote: --- src/udev/udevd.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/udev/udevd.c b/src/udev/udevd.c index 193702c..340812b 100644 --- a/src/udev/udevd.c +++

Re: [systemd-devel] [PATCH] udev: Remove hard-coded string offsets when parsing kernel command line.

2014-11-05 Thread Richard W.M. Jones
On Wed, Nov 05, 2014 at 12:54:21PM +0100, David Herrmann wrote: Hi On Wed, Nov 5, 2014 at 10:16 AM, Richard W.M. Jones rjo...@redhat.com wrote: --- src/udev/udevd.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/udev/udevd.c