Re: [systemd-devel] [PATCH] use static_assert instead of assert_cc

2013-01-03 Thread Lennart Poettering
On Thu, 03.01.13 22:47, Thomas H.P. Andersen (pho...@gmail.com) wrote: > > assert_cc() for simple expressions where the expression is readable > > enough as is. > > > > assert_static() for complex expressions where it is worth specifying a > > human readable string. > > > > I hope this makes sense

Re: [systemd-devel] [PATCH] use static_assert instead of assert_cc

2013-01-03 Thread Thomas H.P. Andersen
On Thu, Jan 3, 2013 at 10:34 PM, Lennart Poettering wrote: > On Sat, 29.12.12 02:10, Thomas H.P. Andersen (pho...@gmail.com) wrote: > >> Another item from the todo > > Heya! > > Hmm, so I commited a patch for using assert_static() a few days before > you did your patches but unfortunately never co

Re: [systemd-devel] [PATCH] use static_assert instead of assert_cc

2013-01-03 Thread Lennart Poettering
On Thu, 03.01.13 22:34, Lennart Poettering (lenn...@poettering.net) wrote: > > On Sat, 29.12.12 02:10, Thomas H.P. Andersen (pho...@gmail.com) wrote: > > > Another item from the todo > > Heya! > > Hmm, so I commited a patch for using assert_static() a few days before > you did your patches but

Re: [systemd-devel] [PATCH] use static_assert instead of assert_cc

2013-01-03 Thread Lennart Poettering
On Sat, 29.12.12 02:10, Thomas H.P. Andersen (pho...@gmail.com) wrote: > Another item from the todo Heya! Hmm, so I commited a patch for using assert_static() a few days before you did your patches but unfortunately never commited it. It works a bit differently from your patch, i.e. keeps asser

Re: [systemd-devel] [PATCH] use static_assert instead of assert_cc

2012-12-30 Thread Thomas H.P. Andersen
On Sun, Dec 30, 2012 at 4:32 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Sat, Dec 29, 2012 at 11:14:15PM +0100, Thomas H.P. Andersen wrote: >> On Sat, Dec 29, 2012 at 5:04 PM, Zbigniew Jędrzejewski-Szmek >> wrote: >> > On Sat, Dec 29, 2012 at 02:10:27AM +0100, Thomas H.P. Andersen wrote: >> >> An

Re: [systemd-devel] [PATCH] use static_assert instead of assert_cc

2012-12-30 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Dec 29, 2012 at 11:14:15PM +0100, Thomas H.P. Andersen wrote: > On Sat, Dec 29, 2012 at 5:04 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Sat, Dec 29, 2012 at 02:10:27AM +0100, Thomas H.P. Andersen wrote: > >> Another item from the todo > > Hi, > > > > the patch looks great, but it rais

Re: [systemd-devel] [PATCH] use static_assert instead of assert_cc

2012-12-29 Thread Thomas H.P. Andersen
On Sat, Dec 29, 2012 at 5:04 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Sat, Dec 29, 2012 at 02:10:27AM +0100, Thomas H.P. Andersen wrote: >> Another item from the todo > Hi, > > the patch looks great, but it raises compatibility problems. AFAICT, > required gcc version to raised to 4.6. Debian/s

Re: [systemd-devel] [PATCH] use static_assert instead of assert_cc

2012-12-29 Thread Michael Biebl
Hi, 2012/12/29 Zbigniew Jędrzejewski-Szmek : > On Sat, Dec 29, 2012 at 02:10:27AM +0100, Thomas H.P. Andersen wrote: >> Another item from the todo > the patch looks great, but it raises compatibility problems. AFAICT, > required gcc version to raised to 4.6. Debian/squeeze has 4.4. Also, While I

Re: [systemd-devel] [PATCH] use static_assert instead of assert_cc

2012-12-29 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Dec 29, 2012 at 02:10:27AM +0100, Thomas H.P. Andersen wrote: > Another item from the todo Hi, the patch looks great, but it raises compatibility problems. AFAICT, required gcc version to raised to 4.6. Debian/squeeze has 4.4. Also, clang has _Static_assert, not static_assert. I think that

[systemd-devel] [PATCH] use static_assert instead of assert_cc

2012-12-28 Thread Thomas H.P. Andersen
Another item from the todo 0001-use-static_assert-instead-of-assert_cc.patch Description: Binary data ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel