Re: [systemd-devel] [PATCH] util, utf8: recognize wide characters in wellipsize_mem()

2013-09-11 Thread Shawn Landden
Original Message From: "Zbigniew Jędrzejewski-Szmek" To: shawnland...@gmail.com CC: systemd-devel@lists.freedesktop.org, "Shawn Landden" Sent: Tue, Sep 10, 2013, 08:59 Subject: Re: [systemd-devel] [PATCH] util, utf8: recognize wide characters in wellipsize_m

Re: [systemd-devel] [PATCH] util, utf8: recognize wide characters in wellipsize_mem()

2013-09-10 Thread Zbigniew Jędrzejewski-Szmek
Hi Shawn, thank you for attacking this, and sorry for the long delay in answering. I think that the approach of copying working code from elsewhere for this is right, but I think it should go into its own file, so that two coding styles are not mixed. Also, can those new functions replace normal e

Re: [systemd-devel] [PATCH] util, utf8: recognize wide characters in wellipsize_mem()

2013-08-28 Thread Shawn
here is the test runner I am using, doesn't really make sense to add this to the tree as it has to be visually inspected diff --git a/Makefile.am b/Makefile.am index cdbfdea..8813299 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1124,6 +1124,7 @@ tests += \ test-unit-file \ test-u

[systemd-devel] [PATCH] util, utf8: recognize wide characters in wellipsize_mem()

2013-08-28 Thread Shawn Landden
--- src/shared/utf8.c | 64 +++ src/shared/utf8.h | 4 +++- src/shared/util.c | 19 ++--- src/shared/util.h | 1 + 4 files changed, 84 insertions(+), 4 deletions(-) diff --git a/src/shared/utf8.c b/src/shared/utf8.c index 8a37c3a..