Re: [systemd-devel] [PATCH] util: add rename_noreplace

2015-03-12 Thread Lennart Poettering
On Tue, 10.03.15 16:16, Alban Crequy (alban.cre...@gmail.com) wrote: > -if (renameat2(AT_FDCWD, t, AT_FDCWD, to, replace ? 0 : > RENAME_NOREPLACE) < 0) { > -unlink_noerrno(t); > -return -errno; > +if (replace) { > +if (renameat(AT_FD

Re: [systemd-devel] [PATCH] util: add rename_noreplace

2015-03-10 Thread Alban Crequy
Comments inline: On Tue, Mar 10, 2015 at 4:25 PM, Lennart Poettering wrote: > On Tue, 10.03.15 16:16, Alban Crequy (alban.cre...@gmail.com) wrote: > >> -if (renameat2(AT_FDCWD, t, AT_FDCWD, to, replace ? 0 : >> RENAME_NOREPLACE) < 0) { >> -unlink_noerrno(t); >> -

[systemd-devel] [PATCH] util: add rename_noreplace

2015-03-10 Thread Alban Crequy
From: Alban Crequy renameat2() exists since Linux 3.15 but btrfs support for the flag RENAME_NOREPLACE was added later. This patch implements a fallback when renameat2() returns EINVAL. EINVAL is the error returned when the filesystem does not support one of the flags. --- src/import/import-raw