Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-30 Thread Christian Seiler
On 05/30/2015 12:42 PM, Daniel Mack wrote: > On 05/30/2015 12:31 PM, Christian Seiler wrote: >> Speaking of: using 'echo' for shell scripting is problematic, because >> while bash, busybox's sh, mksh, pdksh and zsh don't interpret escape >> sequences (\n, \0oo, ...) by default when using echo and i

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-30 Thread Daniel Mack
On 05/30/2015 12:31 PM, Christian Seiler wrote: > On 05/30/2015 10:28 AM, Daniel Mack wrote: >> On 05/30/2015 08:50 AM, Mike Gilbert wrote: >>> On Fri, May 29, 2015 at 8:05 PM, Daniel Mack wrote: Make sure the variable set via --with-rootprefix= does not contain a trailing slash, so man

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-30 Thread Christian Seiler
On 05/30/2015 10:28 AM, Daniel Mack wrote: > On 05/30/2015 08:50 AM, Mike Gilbert wrote: >> On Fri, May 29, 2015 at 8:05 PM, Daniel Mack wrote: >>> Make sure the variable set via --with-rootprefix= does not contain a >>> trailing slash, so man pages can use entities like "&rootprefix;/lib" >>> wit

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-30 Thread Daniel Mack
On 05/30/2015 08:50 AM, Mike Gilbert wrote: > On Fri, May 29, 2015 at 8:05 PM, Daniel Mack wrote: >> Make sure the variable set via --with-rootprefix= does not contain a >> trailing slash, so man pages can use entities like "&rootprefix;/lib" >> without ending up having double slashes. >> --- >>

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Mike Gilbert
On Fri, May 29, 2015 at 8:05 PM, Daniel Mack wrote: > Make sure the variable set via --with-rootprefix= does not contain a > trailing slash, so man pages can use entities like "&rootprefix;/lib" > without ending up having double slashes. > --- > configure.ac | 3 ++- > 1 file changed, 2 insertion

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Filipe Brandenburger
Hi, On Fri, May 29, 2015 at 6:04 PM, Michael Biebl wrote: > I we assume, autconf-archive is installed, the resulting patch would > look like the attached diff. > For convenience sake, we could also ship a copy of > /usr/share/aclocal/ax_normalize_path.m4 in our m4/ directory. Yep... indeed autoc

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:53 GMT+02:00 Michael Biebl : > 2015-05-30 2:50 GMT+02:00 Michael Biebl : >> 2015-05-30 2:24 GMT+02:00 Daniel Mack : >>> >>> Fine for me, just go ahead if you have an implementation in mind :) >> >> I was lazy and just copied >> ftp://ftp.tu-clausthal.de/pub/mirror/gnu/www/software/ac-a

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:50 GMT+02:00 Michael Biebl : > 2015-05-30 2:24 GMT+02:00 Daniel Mack : >> >> Fine for me, just go ahead if you have an implementation in mind :) > > I was lazy and just copied > ftp://ftp.tu-clausthal.de/pub/mirror/gnu/www/software/ac-archive/normpath.html Oh, I just noticed there is

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:24 GMT+02:00 Daniel Mack : > > Fine for me, just go ahead if you have an implementation in mind :) I was lazy and just copied ftp://ftp.tu-clausthal.de/pub/mirror/gnu/www/software/ac-archive/normpath.html The resulting diff would look something like diff --git a/configure.ac b/config

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:30 GMT+02:00 Filipe Brandenburger : > On Fri, May 29, 2015 at 5:21 PM, Michael Biebl wrote: >> autoconf already strips trailing slashes for all default directory >> variables [1]. > > How does it handle --prefix=/ though? Does it turn it into an empty string? Hm, no, apparently it do

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Filipe Brandenburger
On Fri, May 29, 2015 at 5:21 PM, Michael Biebl wrote: > autoconf already strips trailing slashes for all default directory > variables [1]. How does it handle --prefix=/ though? Does it turn it into an empty string? > I think we should do the same for *all* our custom --with-$foo-dir > variables

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Daniel Mack
On 05/30/2015 02:21 AM, Michael Biebl wrote: > 2015-05-30 2:05 GMT+02:00 Daniel Mack : >> Make sure the variable set via --with-rootprefix= does not contain a >> trailing slash, so man pages can use entities like "&rootprefix;/lib" >> without ending up having double slashes. >> --- >> configure.ac

Re: [systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Michael Biebl
2015-05-30 2:05 GMT+02:00 Daniel Mack : > Make sure the variable set via --with-rootprefix= does not contain a > trailing slash, so man pages can use entities like "&rootprefix;/lib" > without ending up having double slashes. > --- > configure.ac | 3 ++- > 1 file changed, 2 insertions(+), 1 delet

[systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

2015-05-29 Thread Daniel Mack
Make sure the variable set via --with-rootprefix= does not contain a trailing slash, so man pages can use entities like "&rootprefix;/lib" without ending up having double slashes. --- configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac ind