Re: [systemd-devel] [PATCH 1/2] manager: connect to private bus even if $DBUS_SESSION_BUS_ADDRESS is not set

2013-10-13 Thread Colin Walters
On Wed, 2013-10-09 at 17:33 +0300, Mantas Mikulėnas wrote: > On Wed, Oct 9, 2013 at 3:59 PM, Colin Walters wrote: > > Your patch seems to be at odds with the commit message; since > > DBUS_SESSION_BUS_ADDRESS won't be set for the user bus, we won't > > attempt a connection, right? > > In the curr

Re: [systemd-devel] [PATCH 1/2] manager: connect to private bus even if $DBUS_SESSION_BUS_ADDRESS is not set

2013-10-09 Thread Mantas Mikulėnas
On Wed, Oct 9, 2013 at 3:59 PM, Colin Walters wrote: > Your patch seems to be at odds with the commit message; since > DBUS_SESSION_BUS_ADDRESS won't be set for the user bus, we won't > attempt a connection, right? In the current code? Yes, but then it won't attempt to set up the *private* socket

Re: [systemd-devel] [PATCH 1/2] manager: connect to private bus even if $DBUS_SESSION_BUS_ADDRESS is not set

2013-10-09 Thread Colin Walters
Your patch seems to be at odds with the commit message; since DBUS_SESSION_BUS_ADDRESS won't be set for the user bus, we won't attempt a connection, right? What you're really trying to fix I assume is the warning systemd outputs when it currently spawns user@? Note I also patched this code in htt

[systemd-devel] [PATCH 1/2] manager: connect to private bus even if $DBUS_SESSION_BUS_ADDRESS is not set

2013-10-09 Thread Mantas Mikulėnas
Because that's exactly the kind of situation where the private bus is necessary. --- src/core/manager.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index 58dacdc..e183325 100644 --- a/src/core/manager.c +++ b/src/c