Re: [systemd-devel] [PATCH 1/2] sd-event: be more careful when enabling/disabling signals

2014-10-08 Thread Lennart Poettering
On Sun, 05.10.14 20:42, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: @@ -626,11 +634,13 @@ static void source_disconnect(sd_event_source *s) { case SOURCE_SIGNAL: if (s-signal.sig 0) { -if (s-signal.sig != SIGCHLD ||

Re: [systemd-devel] [PATCH 1/2] sd-event: be more careful when enabling/disabling signals

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 09:44:33PM +0200, Lennart Poettering wrote: On Sun, 05.10.14 20:42, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: @@ -626,11 +634,13 @@ static void source_disconnect(sd_event_source *s) { case SOURCE_SIGNAL: if

[systemd-devel] [PATCH 1/2] sd-event: be more careful when enabling/disabling signals

2014-10-05 Thread Zbigniew Jędrzejewski-Szmek
When a child event is disabled (in order to be freed) and there is no SIGCHLD signal event, sd_event_source_set_enabled will disable SIGCHLD even if there are other child events. Also remove some unneeded signalfd updates. https://bugs.freedesktop.org/show_bug.cgi?id=84659 Based-on-a-patch-by: