Re: [systemd-devel] [PATCH 1/2] test-hashmap.c first part

2013-04-26 Thread Kay Sievers
On Fri, Apr 26, 2013 at 7:46 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Apr 26, 2013 at 06:40:07PM +0200, Daniel Buch wrote: >> Hi, >> >> So this is comming along, and i want to finish this soon but i got a >> question; > Looks good. I haven't looked at the details, but if passes valgrind,

Re: [systemd-devel] [PATCH 1/2] test-hashmap.c first part

2013-04-26 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 26, 2013 at 06:40:07PM +0200, Daniel Buch wrote: > Hi, > > So this is comming along, and i want to finish this soon but i got a question; Looks good. I haven't looked at the details, but if passes valgrind, and someone looks it over, it can surely go in. > * What are do you think abou

[systemd-devel] [PATCH 1/2] test-hashmap.c first part

2013-04-26 Thread Daniel Buch
Hi, So this is comming along, and i want to finish this soon but i got a question; * What are do you think about using strv_new() + friends for allocateing hashmap values/keys insted of strdup()'s ? --- Makefile.am | 12 +- src/test/test-hashmap.c | 506 ++