Re: [systemd-devel] [PATCH 1/3] Add helper for fnmatch over strv

2015-02-16 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Feb 16, 2015 at 07:43:35PM +0100, Lennart Poettering wrote: > On Mon, 16.02.15 19:38, Tom Gundersen (t...@jklm.no) wrote: > > > Perfect! Thanks! > > No, not perfect at all: > > $ ./test-network > Assertion 's' failed at ./src/shared/strv.h:152, function > strv_fnmatch_or_empty(). Aborti

Re: [systemd-devel] [PATCH 1/3] Add helper for fnmatch over strv

2015-02-16 Thread Lennart Poettering
On Mon, 16.02.15 19:38, Tom Gundersen (t...@jklm.no) wrote: > Perfect! Thanks! No, not perfect at all: $ ./test-network Assertion 's' failed at ./src/shared/strv.h:152, function strv_fnmatch_or_empty(). Aborting. Aborted (core dumped) Lennart -- Lennart Poettering, Red Hat __

Re: [systemd-devel] [PATCH 1/3] Add helper for fnmatch over strv

2015-02-16 Thread Tom Gundersen
Perfect! Thanks! ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 1/3] Add helper for fnmatch over strv

2015-02-16 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Feb 16, 2015 at 06:47:32PM +0100, Tom Gundersen wrote: > On Mon, Feb 16, 2015 at 3:51 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Mon, Feb 16, 2015 at 03:20:21PM +0100, Tom Gundersen wrote: > >> On Mon, Feb 16, 2015 at 2:54 PM, Zbigniew Jędrzejewski-Szmek > >> wrote: > >> > On Mon, Fe

Re: [systemd-devel] [PATCH 1/3] Add helper for fnmatch over strv

2015-02-16 Thread Tom Gundersen
On Mon, Feb 16, 2015 at 3:51 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Mon, Feb 16, 2015 at 03:20:21PM +0100, Tom Gundersen wrote: >> On Mon, Feb 16, 2015 at 2:54 PM, Zbigniew Jędrzejewski-Szmek >> wrote: >> > On Mon, Feb 16, 2015 at 02:12:38PM +0100, Lennart Poettering wrote: >> >> On Sat, 14.

Re: [systemd-devel] [PATCH 1/3] Add helper for fnmatch over strv

2015-02-16 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Feb 16, 2015 at 03:20:21PM +0100, Tom Gundersen wrote: > On Mon, Feb 16, 2015 at 2:54 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Mon, Feb 16, 2015 at 02:12:38PM +0100, Lennart Poettering wrote: > >> On Sat, 14.02.15 00:53, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) > >> wrote: >

Re: [systemd-devel] [PATCH 1/3] Add helper for fnmatch over strv

2015-02-16 Thread Tom Gundersen
On Mon, Feb 16, 2015 at 2:54 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Mon, Feb 16, 2015 at 02:12:38PM +0100, Lennart Poettering wrote: >> On Sat, 14.02.15 00:53, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) >> wrote: >> >> > No functional change intended. >> >> I like this simplification! >

Re: [systemd-devel] [PATCH 1/3] Add helper for fnmatch over strv

2015-02-16 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Feb 16, 2015 at 02:12:38PM +0100, Lennart Poettering wrote: > On Sat, 14.02.15 00:53, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > No functional change intended. > > I like this simplification! > > > > > if (match_host && !condition_test(match_host)) > >

Re: [systemd-devel] [PATCH 1/3] Add helper for fnmatch over strv

2015-02-16 Thread Lennart Poettering
On Sat, 14.02.15 00:53, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > No functional change intended. I like this simplification! > > if (match_host && !condition_test(match_host)) > return false; > @@ -117,49 +112,17 @@ bool net_match_config(const struct et

[systemd-devel] [PATCH 1/3] Add helper for fnmatch over strv

2015-02-13 Thread Zbigniew Jędrzejewski-Szmek
No functional change intended. --- src/analyze/analyze.c | 46 --- src/libsystemd-network/network-internal.c | 53 +-- src/shared/strv.c | 10 ++ src/shared/strv.h | 9 +