Re: [systemd-devel] [PATCH 1/3] Add more password agent information

2014-03-25 Thread David Härdeman
On Tue, Mar 25, 2014 at 09:50:10AM +0100, Benjamin SANS wrote: * On Tuesday, 25 March 2014 01:46, David Härdeman da...@hardeman.nu wrote: Bejamin's approach does not seem to solve the binary key part of the puzzle either...(passing binary keys from the keyscript, as opposed to passphrases).

Re: [systemd-devel] [PATCH 1/3] Add more password agent information

2014-03-24 Thread Lennart Poettering
On Wed, 12.02.14 23:55, David Härdeman (da...@hardeman.nu) wrote: Sorry for the late review! Add an (optional) Id key in the password agent .ask files. The Id is supposed to be a simple string in subsystem:target form which is used to provide more information on what the requested passphrase

Re: [systemd-devel] [PATCH 1/3] Add more password agent information

2014-03-24 Thread David Härdeman
On Tue, Mar 25, 2014 at 01:03:48AM +0100, Lennart Poettering wrote: On Wed, 12.02.14 23:55, David Härdeman (da...@hardeman.nu) wrote: Add an (optional) Id key in the password agent .ask files. The Id is supposed to be a simple string in subsystem:target form which is used to provide more

Re: [systemd-devel] [PATCH 1/3] Add more password agent information

2014-03-24 Thread Lennart Poettering
On Tue, 25.03.14 01:46, David Härdeman (da...@hardeman.nu) wrote: So yes, I think they're related...as in they are independent implementations of the same thing :) Would be great on settle on a common implementation... ;-) Also, please use strappend() for cases like this, where we just want

Re: [systemd-devel] [PATCH 1/3] Add more password agent information

2014-03-24 Thread David Härdeman
On Tue, Mar 25, 2014 at 01:03:48AM +0100, Lennart Poettering wrote: On Wed, 12.02.14 23:55, David Härdeman (da...@hardeman.nu) wrote: -r = ask_password_auto(text, drive-harddisk, until, accept_cached, passwords); +if (asprintf(id, cryptsetup:%s, name) 0) +return

Re: [systemd-devel] [PATCH 1/3] Add more password agent information

2014-03-24 Thread Lennart Poettering
On Tue, 25.03.14 02:13, David Härdeman (da...@hardeman.nu) wrote: Also, please use strappend() for cases like this, where we just want to concatenate two strings. Hmmm, the asprinf use there matches the style of the code of the rest of the functionfor example, with the patch applied

[systemd-devel] [PATCH 1/3] Add more password agent information

2014-02-12 Thread David Härdeman
Add an (optional) Id key in the password agent .ask files. The Id is supposed to be a simple string in subsystem:target form which is used to provide more information on what the requested passphrase is to be used for (which e.g. allows an agent to only react to cryptsetup requests). ---