Re: [systemd-devel] [PATCH 2/2] backlight: Avoid restoring brightness to an unreadably dim level

2014-03-12 Thread Lennart Poettering
On Tue, 11.03.14 21:16, Josh Triplett (j...@joshtriplett.org) wrote: Some systems turn the backlight all the way off at the lowest levels. Clamp saved brightness to at least 1 or 5% of max_brightness. This avoids preserving an unreadably dim screen, which would otherwise force the user to

Re: [systemd-devel] [PATCH 2/2] backlight: Avoid restoring brightness to an unreadably dim level

2014-03-12 Thread Lennart Poettering
On Wed, 12.03.14 08:47, j...@joshtriplett.org (j...@joshtriplett.org) wrote: On Wed, Mar 12, 2014 at 04:44:55PM +0100, Lennart Poettering wrote: On Tue, 11.03.14 21:16, Josh Triplett (j...@joshtriplett.org) wrote: Some systems turn the backlight all the way off at the lowest levels.

[systemd-devel] [PATCH 2/2] backlight: Avoid restoring brightness to an unreadably dim level

2014-03-11 Thread Josh Triplett
Some systems turn the backlight all the way off at the lowest levels. Clamp saved brightness to at least 1 or 5% of max_brightness. This avoids preserving an unreadably dim screen, which would otherwise force the user to disable state restoration. --- src/backlight/backlight.c | 39

Re: [systemd-devel] [PATCH 2/2] backlight: Avoid restoring brightness to an unreadably dim level

2014-03-11 Thread Lennart Poettering
On Tue, 11.03.14 18:55, Josh Triplett (j...@joshtriplett.org) wrote: +/* Some systems turn the backlight all the way off at the + * lowest levels. Clamp saved brightness to at least 1 or 5% + * of max_brightness. This avoids preserving an

Re: [systemd-devel] [PATCH 2/2] backlight: Avoid restoring brightness to an unreadably dim level

2014-03-11 Thread Josh Triplett
On Wed, Mar 12, 2014 at 03:32:47AM +0100, Lennart Poettering wrote: On Tue, 11.03.14 18:55, Josh Triplett (j...@joshtriplett.org) wrote: +/* Some systems turn the backlight all the way off at the + * lowest levels. Clamp saved brightness to at least 1 or

[systemd-devel] [PATCH 2/2] backlight: Avoid restoring brightness to an unreadably dim level

2014-03-11 Thread Josh Triplett
Some systems turn the backlight all the way off at the lowest levels. Clamp saved brightness to at least 1 or 5% of max_brightness. This avoids preserving an unreadably dim screen, which would otherwise force the user to disable state restoration. --- v2: Send the right patch this time. Factor