Re: [systemd-devel] [PATCH 2/2] test: test for ellipsize (manual)

2013-10-17 Thread Shawn
On Sun, Oct 13, 2013 at 4:46 PM, Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > On Sun, Oct 06, 2013 at 05:20:58AM +0200, Zbigniew Jędrzejewski-Szmek > wrote: > > Hi, > > > > sorry for the long delay. I was expecting this review to take > > some time, and I was right :) > > > > I start

Re: [systemd-devel] [PATCH 2/2] test: test for ellipsize (manual)

2013-10-13 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Oct 06, 2013 at 05:20:58AM +0200, Zbigniew Jędrzejewski-Szmek wrote: > Hi, > > sorry for the long delay. I was expecting this review to take > some time, and I was right :) > > I started by running test-ellipsize under valgrind, and found > that there unitialized memory was written. There

Re: [systemd-devel] [PATCH 2/2] test: test for ellipsize (manual)

2013-10-05 Thread Zbigniew Jędrzejewski-Szmek
Hi, sorry for the long delay. I was expecting this review to take some time, and I was right :) I started by running test-ellipsize under valgrind, and found that there unitialized memory was written. There was a bug in ellipsize_mem: when the string was short enough to fit whole, the middle part

[systemd-devel] [PATCH 2/2] test: test for ellipsize (manual)

2013-09-20 Thread Shawn Landden
--- Makefile.am | 7 +++ src/test/test-ellipsize.c | 42 ++ 2 files changed, 49 insertions(+) create mode 100644 src/test/test-ellipsize.c diff --git a/Makefile.am b/Makefile.am index 89a5c86..802f6eb 100644 --- a/Makefile.am +++ b/Makef