Hi
On Mon, Nov 3, 2014 at 1:50 PM, Lennart Poettering
wrote:
> On Mon, 03.11.14 13:46, David Herrmann (dh.herrm...@gmail.com) wrote:
>
>> static inline int negative_errno(void) {
>> assert_return(errno > 0, -EINVAL);
>> return -errno;
>> }
>
> Looks great to me!
>
> But please add
On Mon, 03.11.14 13:46, David Herrmann (dh.herrm...@gmail.com) wrote:
> static inline int negative_errno(void) {
> assert_return(errno > 0, -EINVAL);
> return -errno;
> }
Looks great to me!
But please add a comment next to it, explaining why to use this. I
mean, we should really
On Mon, Nov 3, 2014 at 1:46 PM, David Herrmann wrote:
> On Mon, Nov 3, 2014 at 1:44 PM, Zbigniew Jędrzejewski-Szmek
> wrote:
>> On Mon, Nov 03, 2014 at 01:41:20PM +0100, Lennart Poettering wrote:
>>> On Mon, 03.11.14 13:12, David Herrmann (dh.herrm...@gmail.com) wrote:
>>>
>>> > Hi
>>> >
>>> > On
Hi
On Mon, Nov 3, 2014 at 1:44 PM, Zbigniew Jędrzejewski-Szmek
wrote:
> On Mon, Nov 03, 2014 at 01:41:20PM +0100, Lennart Poettering wrote:
>> On Mon, 03.11.14 13:12, David Herrmann (dh.herrm...@gmail.com) wrote:
>>
>> > Hi
>> >
>> > On Thu, Oct 16, 2014 at 11:43 PM, wrote:
>> > > From: Philipp
On Mon, Nov 03, 2014 at 01:41:20PM +0100, Lennart Poettering wrote:
> On Mon, 03.11.14 13:12, David Herrmann (dh.herrm...@gmail.com) wrote:
>
> > Hi
> >
> > On Thu, Oct 16, 2014 at 11:43 PM, wrote:
> > > From: Philippe De Swert
> > >
> > > Remove the following warning during the compilation:
>
On Mon, 03.11.14 13:12, David Herrmann (dh.herrm...@gmail.com) wrote:
> Hi
>
> On Thu, Oct 16, 2014 at 11:43 PM, wrote:
> > From: Philippe De Swert
> >
> > Remove the following warning during the compilation:
> > src/libsystemd-terminal/grdev-drm.c: In function 'grdrm_card_hotplug':
> > src/li
On Mon, Nov 3, 2014 at 1:12 PM, David Herrmann wrote:
> Hi
>
> On Thu, Oct 16, 2014 at 11:43 PM, wrote:
>> From: Philippe De Swert
>>
>> Remove the following warning during the compilation:
>> src/libsystemd-terminal/grdev-drm.c: In function 'grdrm_card_hotplug':
>> src/libsystemd-terminal/grde
Hi
On Thu, Oct 16, 2014 at 11:43 PM, wrote:
> From: Philippe De Swert
>
> Remove the following warning during the compilation:
> src/libsystemd-terminal/grdev-drm.c: In function 'grdrm_card_hotplug':
> src/libsystemd-terminal/grdev-drm.c:1087:45: warning: 'fb' may be used
> uninitialized in th
From: Philippe De Swert
Remove the following warning during the compilation:
src/libsystemd-terminal/grdev-drm.c: In function 'grdrm_card_hotplug':
src/libsystemd-terminal/grdev-drm.c:1087:45: warning: 'fb' may be used
uninitialized in this function [-Wmaybe-uninitialized]
src/libsystemd-termina
