Re: [systemd-devel] [PATCH 2/5] libsystemd:terminal :fix uninitialized warning

2014-11-04 Thread David Herrmann
Hi On Mon, Nov 3, 2014 at 1:50 PM, Lennart Poettering lenn...@poettering.net wrote: On Mon, 03.11.14 13:46, David Herrmann (dh.herrm...@gmail.com) wrote: static inline int negative_errno(void) { assert_return(errno 0, -EINVAL); return -errno; } Looks great to me! But

Re: [systemd-devel] [PATCH 2/5] libsystemd:terminal :fix uninitialized warning

2014-11-03 Thread David Herrmann
Hi On Thu, Oct 16, 2014 at 11:43 PM, philippedesw...@gmail.com wrote: From: Philippe De Swert philippedesw...@gmail.com Remove the following warning during the compilation: src/libsystemd-terminal/grdev-drm.c: In function 'grdrm_card_hotplug': src/libsystemd-terminal/grdev-drm.c:1087:45:

Re: [systemd-devel] [PATCH 2/5] libsystemd:terminal :fix uninitialized warning

2014-11-03 Thread Tom Gundersen
On Mon, Nov 3, 2014 at 1:12 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Thu, Oct 16, 2014 at 11:43 PM, philippedesw...@gmail.com wrote: From: Philippe De Swert philippedesw...@gmail.com Remove the following warning during the compilation: src/libsystemd-terminal/grdev-drm.c: In

Re: [systemd-devel] [PATCH 2/5] libsystemd:terminal :fix uninitialized warning

2014-11-03 Thread Lennart Poettering
On Mon, 03.11.14 13:12, David Herrmann (dh.herrm...@gmail.com) wrote: Hi On Thu, Oct 16, 2014 at 11:43 PM, philippedesw...@gmail.com wrote: From: Philippe De Swert philippedesw...@gmail.com Remove the following warning during the compilation: src/libsystemd-terminal/grdev-drm.c: In

Re: [systemd-devel] [PATCH 2/5] libsystemd:terminal :fix uninitialized warning

2014-11-03 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Nov 03, 2014 at 01:41:20PM +0100, Lennart Poettering wrote: On Mon, 03.11.14 13:12, David Herrmann (dh.herrm...@gmail.com) wrote: Hi On Thu, Oct 16, 2014 at 11:43 PM, philippedesw...@gmail.com wrote: From: Philippe De Swert philippedesw...@gmail.com Remove the following

Re: [systemd-devel] [PATCH 2/5] libsystemd:terminal :fix uninitialized warning

2014-11-03 Thread David Herrmann
Hi On Mon, Nov 3, 2014 at 1:44 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Mon, Nov 03, 2014 at 01:41:20PM +0100, Lennart Poettering wrote: On Mon, 03.11.14 13:12, David Herrmann (dh.herrm...@gmail.com) wrote: Hi On Thu, Oct 16, 2014 at 11:43 PM,

[systemd-devel] [PATCH 2/5] libsystemd:terminal :fix uninitialized warning

2014-10-24 Thread philippedeswert
From: Philippe De Swert philippedesw...@gmail.com Remove the following warning during the compilation: src/libsystemd-terminal/grdev-drm.c: In function 'grdrm_card_hotplug': src/libsystemd-terminal/grdev-drm.c:1087:45: warning: 'fb' may be used uninitialized in this function