Re: [systemd-devel] [PATCH 3/3] kdbus: get some creds during meta append for optimization

2014-08-21 Thread Djalal Harouni
On Wed, Aug 20, 2014 at 10:49:22PM +0200, Daniel Mack wrote: On 08/20/2014 06:16 PM, Djalal Harouni wrote: On Tue, Aug 19, 2014 at 09:15:35AM +0200, Daniel Mack wrote: Hmm, I'm not convinced this buys us anything really. After all, that struct has a single user only, and factoring out

Re: [systemd-devel] [PATCH 3/3] kdbus: get some creds during meta append for optimization

2014-08-20 Thread Djalal Harouni
On Tue, Aug 19, 2014 at 09:15:35AM +0200, Daniel Mack wrote: Hi Djalal, Thanks for applying the others. On 08/19/2014 03:43 AM, Djalal Harouni wrote: Some creds can be gathered during kdbus_meta_append() instead of kdbus_conn_queue_alloc() where they will be gathered for all the

Re: [systemd-devel] [PATCH 3/3] kdbus: get some creds during meta append for optimization

2014-08-20 Thread Daniel Mack
On 08/20/2014 06:16 PM, Djalal Harouni wrote: On Tue, Aug 19, 2014 at 09:15:35AM +0200, Daniel Mack wrote: Hmm, I'm not convinced this buys us anything really. After all, that struct has a single user only, and factoring out these fields doesn't necessarily lead to more readability. Hmm with

Re: [systemd-devel] [PATCH 3/3] kdbus: get some creds during meta append for optimization

2014-08-19 Thread Daniel Mack
Hi Djalal, On 08/19/2014 03:43 AM, Djalal Harouni wrote: Some creds can be gathered during kdbus_meta_append() instead of kdbus_conn_queue_alloc() where they will be gathered for all the receivers and saved into each receivers queue before installing on the slices. By moving to

[systemd-devel] [PATCH 3/3] kdbus: get some creds during meta append for optimization

2014-08-18 Thread Djalal Harouni
Some creds can be gathered during kdbus_meta_append() instead of kdbus_conn_queue_alloc() where they will be gathered for all the receivers and saved into each receivers queue before installing on the slices. By moving to kdbus_meta_append() it permits to do it only one time for all the