Re: [systemd-devel] [PATCH 4/4] cgtop: support time header with user-specified format string

On 28 May 2015 at 09:58, Filipe Brandenburger wrote: > Though I'm not sure whether taking a strftime format as a command line > argument is really a good idea... But I'll defer that to other > reviewers. From working with lua, I recall that accepting arbitary strftime format strings is unsafe in

Re: [systemd-devel] [PATCH 4/4] cgtop: support time header with user-specified format string

Hi, On Wed, May 27, 2015 at 3:40 PM, Charles Duffy wrote: > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Wformat-nonliteral" > +time_len = strftime(buf, l, arg_time_format, curr_time); > +if (time_len <= 0) > +return; > +#pragma GCC diagnostic p

Re: [systemd-devel] [PATCH 4/4] cgtop: support time header with user-specified format string

Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing

[systemd-devel] [PATCH 4/4] cgtop: support time header with user-specified format string

From: Charles Duffy --- src/cgtop/cgtop.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/src/cgtop/cgtop.c b/src/cgtop/cgtop.c index 53e3a64..c3db62b 100644 --- a/src/cgtop/cgtop.c +++ b/src/cgtop/cgtop.c @@ -63,6 +63,8 @@ s