Re: [systemd-devel] [PATCH rebased] Use strlen even for constant strings

2014-03-16 Thread Josh Triplett
On Sun, Mar 16, 2014 at 02:56:10PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Sat, Mar 15, 2014 at 11:40:07AM -0700, Josh Triplett wrote: > > GCC optimizes strlen("string constant") to a constant, even with -O0. > > Thus, replace patterns like sizeof("string constant")-1 with > > strlen("string

Re: [systemd-devel] [PATCH rebased] Use strlen even for constant strings

2014-03-16 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Mar 15, 2014 at 11:40:07AM -0700, Josh Triplett wrote: > GCC optimizes strlen("string constant") to a constant, even with -O0. > Thus, replace patterns like sizeof("string constant")-1 with > strlen("string constant") where possible, for clarity. In particular, > for expressions intended t

[systemd-devel] [PATCH rebased] Use strlen even for constant strings

2014-03-15 Thread Josh Triplett
GCC optimizes strlen("string constant") to a constant, even with -O0. Thus, replace patterns like sizeof("string constant")-1 with strlen("string constant") where possible, for clarity. In particular, for expressions intended to add up the lengths of components going into a string, this often make