Re: [systemd-devel] [PATCH v4] watchdog: Don't require WDIOC_SETOPTIONS/WDIOS_ENABLECARD

2015-06-17 Thread Jean Delvare
On Wed, 17 Jun 2015 19:04:34 +0200, Lennart Poettering wrote: > On Wed, 17.06.15 18:57, Jean Delvare (jdelv...@suse.de) wrote: > > > Not all watchdog drivers implement WDIOC_SETOPTIONS. Drivers which do > > not implement it have their device always enabled. So it's fine to > > report an error if W

Re: [systemd-devel] [PATCH v4] watchdog: Don't require WDIOC_SETOPTIONS/WDIOS_ENABLECARD

2015-06-17 Thread Lennart Poettering
On Wed, 17.06.15 18:57, Jean Delvare (jdelv...@suse.de) wrote: > Not all watchdog drivers implement WDIOC_SETOPTIONS. Drivers which do > not implement it have their device always enabled. So it's fine to > report an error if WDIOS_DISABLECARD is passed and the ioctl is not > implemented, however f

[systemd-devel] [PATCH v4] watchdog: Don't require WDIOC_SETOPTIONS/WDIOS_ENABLECARD

2015-06-17 Thread Jean Delvare
Not all watchdog drivers implement WDIOC_SETOPTIONS. Drivers which do not implement it have their device always enabled. So it's fine to report an error if WDIOS_DISABLECARD is passed and the ioctl is not implemented, however failing when WDIOS_ENABLECARD is passed and the ioctl is not implemented