Re: [systemd-devel] [systemd-commits] load-fragment: use UNESCAPE_RELAX flag to parse exec directives

2015-06-02 Thread Filipe Brandenburger
Pull Request created: https://github.com/systemd/systemd/pull/44 If you could test it and confirm your "sudo" case with \073 works now, and your regexp case isn't broken, I'd appreciate it. Cheers, Filipe On Tue, Jun 2, 2015 at 2:53 PM, Filipe Brandenburger wrote: > Hi Michael, > > On Tue, Jun

Re: [systemd-devel] [systemd-commits] load-fragment: use UNESCAPE_RELAX flag to parse exec directives

2015-06-02 Thread Filipe Brandenburger
Hi Michael, On Tue, Jun 2, 2015 at 2:50 PM, Michael Biebl wrote: > 2015-06-02 12:55 GMT+02:00 Daniel Mack : >> So, my primary motivation was to fix the obvious regression at hand >> first, but I agree the actual problem goes deeper. > > Looks like even with this patch applied, we have regressions

Re: [systemd-devel] [systemd-commits] load-fragment: use UNESCAPE_RELAX flag to parse exec directives

2015-06-02 Thread Michael Biebl
2015-06-02 12:55 GMT+02:00 Daniel Mack : > So, my primary motivation was to fix the obvious regression at hand > first, but I agree the actual problem goes deeper. Looks like even with this patch applied, we have regressions compared to previous releases. See https://bugs.freedesktop.org/show_bug.

Re: [systemd-devel] [systemd-commits] load-fragment: use UNESCAPE_RELAX flag to parse exec directives

2015-06-02 Thread Filipe Brandenburger
On Tue, Jun 2, 2015 at 3:55 AM, Daniel Mack wrote: > The problem here is that cunescape() wasn't as strict in the past as it > should have been, and now there are unit files in the wild which contain > escape sequences that slip through the C unescaping mechanism. > > So, my primary motivation was

Re: [systemd-devel] [systemd-commits] load-fragment: use UNESCAPE_RELAX flag to parse exec directives

2015-06-02 Thread Daniel Mack
Hi Filipe, On 06/02/2015 07:34 AM, Filipe Brandenburger wrote: > On Mon, Jun 1, 2015 at 9:10 AM, Daniel Mack >> diff --git a/src/core/load-fragment.c b/src/core/load-fragment.c >> index c95c110..df5fe6f 100644 >> --- a/src/core/load-fragment.c >> +++ b/src/core/load-fragment.c >> @@ -610,7 +610,7

Re: [systemd-devel] [systemd-commits] load-fragment: use UNESCAPE_RELAX flag to parse exec directives

2015-06-01 Thread Filipe Brandenburger
Hi, Not sure I agree with the commit below. (In particular as I'm looking at converting this code into using unquote_first_word.) On Mon, Jun 1, 2015 at 9:10 AM, Daniel Mack wrote: > commit 22874a348fb1540c1a2b7907748fc57c9756a7ed > Author: Daniel Mack > Date: Mon Jun 1 17:49:04 2015 +0200 >