[systemd-devel] Crash with extra space after Exec prefix

2015-05-13 Thread Martin Pitt
Hello all, I got a report [1] that you can trivially crash systemd (pid1) at boot by creating a unit with an Exec= line with a modifier and a space: $ cat /tmp/foo.service [Service] ExecStart=- /bin/echo hello $ systemd-analyze verify /tmp/foo.service Assertion 'skip l' failed at

Re: [systemd-devel] Crash with extra space after Exec prefix

2015-05-13 Thread Lennart Poettering
On Wed, 13.05.15 17:01, Martin Pitt (martin.p...@ubuntu.com) wrote: Hello all, I got a report [1] that you can trivially crash systemd (pid1) at boot by creating a unit with an Exec= line with a modifier and a space: $ cat /tmp/foo.service [Service] ExecStart=- /bin/echo hello $

Re: [systemd-devel] Crash with extra space after Exec prefix

2015-05-13 Thread Martin Pitt
Lennart Poettering [2015-05-13 17:55 +0200]: On Wed, 13.05.15 17:01, Martin Pitt (martin.p...@ubuntu.com) wrote: So, obviously we need to fix the crash; but I was wondering what the desired behaviour should be? In the sense of be liberal what you accept I think the extra space(s) should

Re: [systemd-devel] Crash with extra space after Exec prefix

2015-05-13 Thread Lennart Poettering
On Wed, 13.05.15 19:11, Martin Pitt (martin.p...@ubuntu.com) wrote: Lennart Poettering [2015-05-13 17:55 +0200]: On Wed, 13.05.15 17:01, Martin Pitt (martin.p...@ubuntu.com) wrote: So, obviously we need to fix the crash; but I was wondering what the desired behaviour should be? In the

Re: [systemd-devel] Crash with extra space after Exec prefix

2015-05-13 Thread Reindl Harald
Am 13.05.2015 um 19:11 schrieb Martin Pitt: Lennart Poettering [2015-05-13 17:55 +0200]: On Wed, 13.05.15 17:01, Martin Pitt (martin.p...@ubuntu.com) wrote: So, obviously we need to fix the crash; but I was wondering what the desired behaviour should be? In the sense of be liberal what you