Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-02-03 Thread Harald Hoyer
On 03.02.2015 00:44, Lennart Poettering wrote: On Tue, 03.02.15 00:27, Lennart Poettering (lenn...@poettering.net) wrote: On Thu, 08.01.15 16:34, Harald Hoyer (harald.ho...@gmail.com) wrote: IMHO systemd-fsck-root.service should be removed entirely and generated by the fstab-generator in

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-02-02 Thread Lennart Poettering
On Tue, 03.02.15 00:27, Lennart Poettering (lenn...@poettering.net) wrote: On Thu, 08.01.15 16:34, Harald Hoyer (harald.ho...@gmail.com) wrote: IMHO systemd-fsck-root.service should be removed entirely and generated by the fstab-generator in the real root like all the other mount

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-02-02 Thread Lennart Poettering
On Thu, 08.01.15 16:34, Harald Hoyer (harald.ho...@gmail.com) wrote: IMHO systemd-fsck-root.service should be removed entirely and generated by the fstab-generator in the real root like all the other mount points. Well, we also need it if there's no /etc/fstab... OR fstab-generator

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-21 Thread Harald Hoyer
On 11.01.2015 12:57, Andrei Borzenkov wrote: Does it using systemd *inside* of initrd? From upstream dracut: if ! dracut_module_included systemd; then inst_hook cmdline 95 $moddir/parse-block.sh inst_hook pre-udev 30 $moddir/block-genrules.sh inst_hook mount 99

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Nikolai Zhubr
Hi, 11.01.2015 1:31, Chris Murphy: Yeah it's a bit messy and I really think to some degree this should be bounced back to the ext developers and say how do you envision this working because doing the right thing for ext4 really burdens multiple other processes: systemd of course, but also

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Chris Murphy
On Sun, Jan 11, 2015 at 4:11 AM, Andrei Borzenkov arvidj...@gmail.com wrote: В Sun, 11 Jan 2015 13:43:34 +0300 Nikolai Zhubr n-a-zh...@yandex.ru пишет: Uh. Why not simply mount rootfs rw in initrd then? I'm not against generally. But it'd mean that this first mount is actually a real

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Andrei Borzenkov
В Sun, 11 Jan 2015 13:43:34 +0300 Nikolai Zhubr n-a-zh...@yandex.ru пишет: Uh. Why not simply mount rootfs rw in initrd then? I'm not against generally. But it'd mean that this first mount is actually a real mount, the fs will start up in full. Then I'd suppose it is definitely a must

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Nikolai Zhubr
Hi, 11.01.2015 10:09, Andrei Borzenkov: Ok. I've invented a quick-and-dirty fix. I'll modify systemd-fsck so that when run with no argument it does nothing and exit successfully. This way I'll still have rootfs fsck'ed every boot, but never twice. Uh. Why not simply mount rootfs rw in initrd

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Chris Murphy
On Sun, Jan 11, 2015 at 3:43 AM, Nikolai Zhubr n-a-zh...@yandex.ru wrote: Hi, 11.01.2015 10:09, Andrei Borzenkov: Ok. I've invented a quick-and-dirty fix. I'll modify systemd-fsck so that when run with no argument it does nothing and exit successfully. This way I'll still have rootfs fsck'ed

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Andrei Borzenkov
В Sun, 11 Jan 2015 04:15:41 -0700 Chris Murphy li...@colorremedies.com пишет: On Sun, Jan 11, 2015 at 4:11 AM, Andrei Borzenkov arvidj...@gmail.com wrote: В Sun, 11 Jan 2015 13:43:34 +0300 Nikolai Zhubr n-a-zh...@yandex.ru пишет: Uh. Why not simply mount rootfs rw in initrd then?

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Chris Murphy
On Sun, Jan 11, 2015 at 4:57 AM, Andrei Borzenkov arvidj...@gmail.com wrote: Does it using systemd *inside* of initrd? I don't know how to find the answer to this. There is an initramfs and systemd-journald is the first thing (other than kernel) to be found in dmesg after the initramfs is

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Nikolai Zhubr
Hi, 11.01.2015 14:11, Andrei Borzenkov: [...] By adding all needed options to rootflags=... (modify GRUB_CMDLINE_LINUX_DEFAULT and possibly GRUB_CMDLINE_LINUX_RECOVERY in /etc/default/grub; you can use yast for it). Ah, indeed. Although it feels a bit ugly because the consistency between fstab

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Chris Murphy
On Sun, Jan 11, 2015 at 4:48 AM, Nikolai Zhubr n-a-zh...@yandex.ru wrote: Hi, 11.01.2015 1:31, Chris Murphy: Yeah it's a bit messy and I really think to some degree this should be bounced back to the ext developers and say how do you envision this working because doing the right thing for

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Andrei Borzenkov
В Sun, 11 Jan 2015 15:22:54 +0300 Nikolai Zhubr n-a-zh...@yandex.ru пишет: Hi, 11.01.2015 14:11, Andrei Borzenkov: [...] By adding all needed options to rootflags=... (modify GRUB_CMDLINE_LINUX_DEFAULT and possibly GRUB_CMDLINE_LINUX_RECOVERY in /etc/default/grub; you can use yast for

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Nikolai Zhubr
Hi, 11.01.2015 15:54, Andrei Borzenkov: It's no more ugly than using privately patched distribution package. I did not suggest it as long term generic solution. Yes, absolutely. Therefore I'm reading all the answers to find a reasonable workaround and avoid whatever ugly patching.

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Nikolai Zhubr
Hi, 11.01.2015 15:04, Chris Murphy: That's all I meant by bouncing back to ext devs. I don't mean there's anything wrong with ext4. It's pretty clear the XFS and Btrfs devs expect that if a normal rw mount fails, that boot fails and we're dropped to a dracut shell with an unmounted root. And

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Nikolai Zhubr
11.01.2015 15:22, Nikolai Zhubr: By adding all needed options to rootflags=... (modify GRUB_CMDLINE_LINUX_DEFAULT and possibly GRUB_CMDLINE_LINUX_RECOVERY in /etc/default/grub; you can use yast for it). Ah, indeed. Although it feels a bit ugly because the consistency between fstab and

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Dave Reisner
On Sun, Jan 11, 2015 at 10:09:08AM +0300, Andrei Borzenkov wrote: В Sat, 10 Jan 2015 16:51:24 +0300 Nikolai Zhubr n-a-zh...@yandex.ru пишет: Hi, 09.01.2015 23:48, Chris Murphy: [...] I might be missing something, but what's wrong with the existing root=... rootfstype=...

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Andrei Borzenkov
В Thu, 08 Jan 2015 21:32:08 +0100 Harald Hoyer harald.ho...@gmail.com пишет: In case of systemd in the initrd, the fstab-generator ensures that fsck is done on root and /usr and any other partition marked with x-initrd.mount. How is it supposed to work? In native systemd mode

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Chris Murphy
On Sun, Jan 11, 2015 at 4:57 AM, Andrei Borzenkov arvidj...@gmail.com wrote: В Sun, 11 Jan 2015 04:15:41 -0700 Does it using systemd *inside* of initrd? From upstream dracut: if ! dracut_module_included systemd; then inst_hook cmdline 95 $moddir/parse-block.sh inst_hook

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Reindl Harald
Am 11.01.2015 um 12:48 schrieb Nikolai Zhubr: I suppose this traditional (historical) technique of maintaining mount-count, running fsck at boot time before remount r/w, etc, should not be so much attributed specifically to ext filesystem. Most probably it existed long before even ext2

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Nikolai Zhubr
Hi, 11.01.2015 23:03, Reindl Harald: Am 11.01.2015 um 12:48 schrieb Nikolai Zhubr: I suppose this traditional (historical) technique of maintaining mount-count, running fsck at boot time before remount r/w, etc, should not be so much attributed specifically to ext filesystem. Most probably it

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Chris Murphy
On Sun, Jan 11, 2015 at 2:14 PM, Nikolai Zhubr n-a-zh...@yandex.ru wrote: Hi, 11.01.2015 23:03, Reindl Harald: Am 11.01.2015 um 12:48 schrieb Nikolai Zhubr: I suppose this traditional (historical) technique of maintaining mount-count, running fsck at boot time before remount r/w, etc,

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Nikolai Zhubr
Hi, 12.01.2015 0:47, Chris Murphy: [...] - man tune2fs uses very strong language to set either interval-between-checks or max-mount-counts. However, mke2fs 1.42.11 (09-Jul-2014) sets neither by default. I'm not sure when this changed, it used to set check interval to 180, but a new file system

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Andrei Borzenkov
В Sun, 11 Jan 2015 12:45:17 -0700 Chris Murphy li...@colorremedies.com пишет: On Sun, Jan 11, 2015 at 4:57 AM, Andrei Borzenkov arvidj...@gmail.com wrote: В Sun, 11 Jan 2015 04:15:41 -0700 Does it using systemd *inside* of initrd? From upstream dracut: if ! dracut_module_included

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Chris Murphy
On Sun, Jan 11, 2015 at 8:29 PM, Andrei Borzenkov arvidj...@gmail.com wrote: В Sun, 11 Jan 2015 12:45:17 -0700 Chris Murphy li...@colorremedies.com пишет: On Sun, Jan 11, 2015 at 4:57 AM, Andrei Borzenkov arvidj...@gmail.com wrote: В Sun, 11 Jan 2015 04:15:41 -0700 Does it using systemd

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-11 Thread Chris Murphy
On Sun, Jan 11, 2015 at 10:13 PM, Chris Murphy li...@colorremedies.com wrote: On Sun, Jan 11, 2015 at 8:29 PM, Andrei Borzenkov arvidj...@gmail.com wrote: В Sun, 11 Jan 2015 12:45:17 -0700 Chris Murphy li...@colorremedies.com пишет: On Sun, Jan 11, 2015 at 4:57 AM, Andrei Borzenkov

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-10 Thread Nikolai Zhubr
Hi, 09.01.2015 23:48, Chris Murphy: [...] I might be missing something, but what's wrong with the existing root=... rootfstype=... rootflags=... rw options? Why is the remount even necessary? Seems to be distro specific. I see rw for opensuse or Ubuntu, and ro for Fedora. The ro seems

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-10 Thread Chris Murphy
On Sat, Jan 10, 2015 at 6:51 AM, Nikolai Zhubr n-a-zh...@yandex.ru wrote: Hope someone will come up with a better solution though :) (There are lots of systems affected to some degree in the wild already) Yeah it's a bit messy and I really think to some degree this should be bounced back to

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-10 Thread Andrei Borzenkov
В Sat, 10 Jan 2015 16:51:24 +0300 Nikolai Zhubr n-a-zh...@yandex.ru пишет: Hi, 09.01.2015 23:48, Chris Murphy: [...] I might be missing something, but what's wrong with the existing root=... rootfstype=... rootflags=... rw options? Why is the remount even necessary? Seems to be

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-09 Thread Nikolai Zhubr
Hi all, 08.01.2015 23:32, Harald Hoyer: [...] Yes, I was about to suggest the same at the end. Where I fill uneasy is hardcoding /dev/root inside of systemd-fsck. In case of dracut this is basically the only thing that we know for sure. Does every initrd implementation use it? Alternative is to

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-09 Thread Mantas Mikulėnas
On Fri, Jan 9, 2015, 11:43 Nikolai Zhubr n-a-zh...@yandex.ru wrote: Hi all, 08.01.2015 23:32, Harald Hoyer: [...] Yes, I was about to suggest the same at the end. Where I fill uneasy is hardcoding /dev/root inside of systemd-fsck. In case of dracut this is basically the only thing that we know

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-09 Thread Chris Murphy
On Fri, Jan 9, 2015 at 3:27 AM, Mantas Mikulėnas graw...@gmail.com wrote: I might be missing something, but what's wrong with the existing root=... rootfstype=... rootflags=... rw options? Why is the remount even necessary? Seems to be distro specific. I see rw for opensuse or Ubuntu, and ro

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-08 Thread Nikolai Zhubr
08.01.2015 5:13, Cristian Rodríguez: Ok. So should I file a report to opensuse bugtracker? Yes, against BaseSystem component. Bug 912209 https://bugzilla.opensuse.org/show_bug.cgi?id=912209 Thank you, Nikolai ___ systemd-devel mailing list

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-08 Thread Harald Hoyer
On 08.01.2015 07:18, Andrei Borzenkov wrote: В Wed, 07 Jan 2015 23:23:27 -0300 Cristian Rodríguez crrodrig...@opensuse.org пишет: El 07/01/15 a las 22:55, Nikolai Zhubr escribió: 08.01.2015 4:12, Cristian Rodríguez: El 07/01/15 a las 21:43, Lennart Poettering escribió: Maybe suse forgot

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-08 Thread Lennart Poettering
On Thu, 08.01.15 16:34, Harald Hoyer (harald.ho...@gmail.com) wrote: IMHO systemd-fsck-root.service should be removed entirely and generated by the fstab-generator in the real root like all the other mount points. Well, this service *is* special, it needs to run before the other fsck, and

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-08 Thread Harald Hoyer
On 08.01.2015 16:55, Lennart Poettering wrote: On Thu, 08.01.15 16:34, Harald Hoyer (harald.ho...@gmail.com) wrote: IMHO systemd-fsck-root.service should be removed entirely and generated by the fstab-generator in the real root like all the other mount points. Well, this service *is*

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-08 Thread Harald Hoyer
On 08.01.2015 18:30, Andrei Borzenkov wrote: В Thu, 08 Jan 2015 17:12:25 +0100 Harald Hoyer harald.ho...@gmail.com пишет: On 08.01.2015 16:55, Lennart Poettering wrote: On Thu, 08.01.15 16:34, Harald Hoyer (harald.ho...@gmail.com) wrote: IMHO systemd-fsck-root.service should be removed

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-07 Thread Andrei Borzenkov
В Wed, 07 Jan 2015 23:23:27 -0300 Cristian Rodríguez crrodrig...@opensuse.org пишет: El 07/01/15 a las 22:55, Nikolai Zhubr escribió: 08.01.2015 4:12, Cristian Rodríguez: El 07/01/15 a las 21:43, Lennart Poettering escribió: Maybe suse forgot to include this service file in the initrd or

[systemd-devel] Second (erroneous) check of rootfs?

2015-01-07 Thread Nikolai Zhubr
Hi, I'm not quite sure if it belongs to systemd or rather dracut or even opensuse bugtracker... Please feel free to redirect me as appropriate. Below is a fragment of jounal of one boot of opensuse 13.2, irrelevant parts replaced by dots to compact it a bit. In short, AFAICS: 1. In initrd,

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-07 Thread Lennart Poettering
On Thu, 08.01.15 03:36, Nikolai Zhubr (n-a-zh...@yandex.ru) wrote: Hi, I'm not quite sure if it belongs to systemd or rather dracut or even opensuse bugtracker... Please feel free to redirect me as appropriate. Below is a fragment of jounal of one boot of opensuse 13.2, irrelevant parts

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-07 Thread Cristian Rodríguez
El 07/01/15 a las 21:43, Lennart Poettering escribió: Maybe suse forgot to include this service file in the initrd or so? Correct. It appears to be a bug in the dracut package. I wonder why .. ___ systemd-devel mailing list

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-07 Thread Nikolai Zhubr
08.01.2015 3:43, Lennart Poettering: [...] The fsck of the root file system is done by systemd-root-fsck.service. It exists both in the initrd and on the host. On my box the first check is performed by systemd-fsck@ (I can see it in the log), and the second by systemd-root-fsck apparently.

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-07 Thread Nikolai Zhubr
08.01.2015 4:12, Cristian Rodríguez: El 07/01/15 a las 21:43, Lennart Poettering escribió: Maybe suse forgot to include this service file in the initrd or so? Correct. It appears to be a bug in the dracut package. I wonder why .. Ok. So should I file a report to opensuse bugtracker? I have

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-07 Thread Cristian Rodríguez
El 07/01/15 a las 22:55, Nikolai Zhubr escribió: 08.01.2015 4:12, Cristian Rodríguez: El 07/01/15 a las 21:43, Lennart Poettering escribió: Maybe suse forgot to include this service file in the initrd or so? Correct. It appears to be a bug in the dracut package. I wonder why .. Ok. So

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-07 Thread Cristian Rodríguez
El 07/01/15 a las 22:55, Nikolai Zhubr escribió: 08.01.2015 4:12, Cristian Rodríguez: El 07/01/15 a las 21:43, Lennart Poettering escribió: Maybe suse forgot to include this service file in the initrd or so? Correct. It appears to be a bug in the dracut package. I wonder why .. Ok. So