Re: [systemd-devel] lighttp unit - graceful reload of configfiles by sending signal to $MAINPID

2011-01-18 Thread Lennart Poettering
On Tue, 18.01.11 16:41, Alexander E. Patrakov (patra...@gmail.com) wrote: How is this implemented in detail? Sending SIGINT is async, so at the time you start the new instance you cannot be sure that the old instance has stopped listening? Indeed, there is a race here. That's why /bin/sleep

Re: [systemd-devel] lighttp unit - graceful reload of configfiles by sending signal to $MAINPID

2011-01-18 Thread Alexander E. Patrakov
18.01.2011 04:48, Lennart Poettering wrote: What systemd currently does is: If the reload fails it shutdowns the service and informs you about the failure. What systemd probably should do (and what is now in the TODO list) is: If the reload fails it should leave the service as

Re: [systemd-devel] lighttp unit - graceful reload of configfiles by sending signal to $MAINPID

2011-01-18 Thread Lennart Poettering
On Tue, 18.01.11 17:56, Alexander E. Patrakov (patra...@gmail.com) wrote: 18.01.2011 16:51, Lennart Poettering пишет: On Tue, 18.01.11 16:41, Alexander E. Patrakov (patra...@gmail.com) wrote: How is this implemented in detail? Sending SIGINT is async, so at the time you start the new

Re: [systemd-devel] lighttp unit - graceful reload of configfiles by sending signal to $MAINPID

2011-01-18 Thread Lennart Poettering
On Tue, 18.01.11 18:00, Alexander E. Patrakov (patra...@gmail.com) wrote: 18.01.2011 04:48, Lennart Poettering wrote: What systemd currently does is: If the reload fails it shutdowns the service and informs you about the failure. What systemd probably should do (and what is

Re: [systemd-devel] lighttp unit - graceful reload of configfiles by sending signal to $MAINPID

2011-01-17 Thread Lennart Poettering
On Tue, 11.01.11 09:54, Alexander E. Patrakov (patra...@gmail.com) wrote: instances of lighttpd to coexist for some time. See: after SIGINT, the old instance does not listen on port 80, but continues servicing large downloads that are still in progress. The new instance accepts new

Re: [systemd-devel] lighttp unit - graceful reload of configfiles by sending signal to $MAINPID

2011-01-17 Thread Lennart Poettering
On Tue, 11.01.11 15:46, Marius Tolzmann (tolzm...@molgen.mpg.de) wrote: hi again.. On 01/11/11 11:51, Alexander E. Patrakov wrote: After more research, I found the under-documented lighttpd-angel program. It does what is needed for babysitting lighttpd: performs the send SIGINT to the

Re: [systemd-devel] lighttp unit - graceful reload of configfiles by sending signal to $MAINPID

2011-01-17 Thread Lennart Poettering
On Mon, 10.01.11 18:49, Marius Tolzmann (tolzm...@molgen.mpg.de) wrote: and why do you explicitly not use the -D option and let systemd do all the forking stuff for you..? you could get rid off the Type= PIDFile= lines.. i also removed StandardError=syslog which seems to be redundant here..

Re: [systemd-devel] lighttp unit - graceful reload of configfiles by sending signal to $MAINPID

2011-01-11 Thread Alexander E. Patrakov
10.01.2011 22:49, Marius Tolzmann wrote: hi.. can the initial problem of restarting the lighttpd gracefully be solved by something like this?: Restart=on-success ( or on-abort or always .. don't know what the exit-status after graceful kill is in lighty) After more research, I found the

Re: [systemd-devel] lighttp unit - graceful reload of configfiles by sending signal to $MAINPID

2011-01-11 Thread Marius Tolzmann
hi again.. On 01/11/11 11:51, Alexander E. Patrakov wrote: After more research, I found the under-documented lighttpd-angel program. It does what is needed for babysitting lighttpd: performs the send SIGINT to the old copy and immediately start the new one dance when it receives SIGHUP. See

Re: [systemd-devel] lighttp unit - graceful reload of configfiles by sending signal to $MAINPID

2011-01-11 Thread Mirco Tischler
Am 11.01.2011 16:11, schrieb Alexander E. Patrakov: Also, the test config before reloading feature still doesn't work right. If I add this ExecReload line before the existing one: ExecReload=/usr/sbin/lighttpd -t -f /etc/lighttpd/lighttpd.conf then systemd will kill lighttpd-angel when the

Re: [systemd-devel] lighttp unit - graceful reload of configfiles by sending signal to $MAINPID

2011-01-11 Thread Marius Tolzmann
hi.. On 01/11/11 16:11, Alexander E. Patrakov wrote: When the config is bad and the additional ExecReload line is present, systemd does tell me that reload failed. So I have a good reason to check syslog, and even am suggested by systemd to do so. sorry my fault 8).. i thought it was

[systemd-devel] lighttp unit - graceful reload of configfiles by sending signal to $MAINPID

2011-01-10 Thread Marius Tolzmann
hi.. [Unit] Description=Lighttpd Web Server After=network.target [Service] Type=forking EnvironmentFile=/etc/conf.d/lighttpd PIDFile=/var/run/lighttpd.pid ExecStartPre=/usr/sbin/lighttpd -t -f /etc/lighttpd/lighttpd.conf ExecStart=/usr/sbin/lighttpd -f /etc/lighttpd/lighttpd.conf

Re: [systemd-devel] lighttp unit - graceful reload of configfiles by sending signal to $MAINPID

2011-01-10 Thread Alexander E. Patrakov
10.01.2011 22:49, Marius Tolzmann wrote: hi.. [Unit] Description=Lighttpd Web Server After=network.target [Service] Type=forking EnvironmentFile=/etc/conf.d/lighttpd PIDFile=/var/run/lighttpd.pid ExecStartPre=/usr/sbin/lighttpd -t -f /etc/lighttpd/lighttpd.conf ExecStart=/usr/sbin/lighttpd