Re: [systemd-devel] [PATCH] Add timesync-wait tool

2014-11-10 Thread Lennart Poettering
On Wed, 29.10.14 17:50, Lukasz Stelmach (stl...@poczta.fm) wrote: I mean, what is the tool supposed to be waiting on: that the time is set as accurately as possible (in that case watching STA_UNSYNC sounds good, plus waiting for TFD_CANCEL_ON_SET for big jumps and guessing sleep times

Re: [systemd-devel] [PATCH] Add timesync-wait tool

2014-10-29 Thread Lukasz Stelmach
On 27.10.2014 15:12, Lennart Poettering wrote: On Fri, 24.10.14 23:13, Lukasz Stelmach (stl...@poczta.fm) wrote: On 24.10.2014 00:28, Lennart Poettering wrote: On Thu, 23.10.14 21:24, Łukasz Stelmach (stl...@poczta.fm) wrote: +int main(int argc, char *argv[]) { +struct timex tbuf;

Re: [systemd-devel] [PATCH] Add timesync-wait tool

2014-10-27 Thread Lennart Poettering
On Fri, 24.10.14 23:13, Lukasz Stelmach (stl...@poczta.fm) wrote: On 24.10.2014 00:28, Lennart Poettering wrote: On Thu, 23.10.14 21:24, Łukasz Stelmach (stl...@poczta.fm) wrote: +int main(int argc, char *argv[]) { +struct timex tbuf; +int r; + +

Re: [systemd-devel] [PATCH] Add timesync-wait tool

2014-10-24 Thread Lukasz Stelmach
On 24.10.2014 00:28, Lennart Poettering wrote: On Thu, 23.10.14 21:24, Łukasz Stelmach (stl...@poczta.fm) wrote: +int main(int argc, char *argv[]) { +struct timex tbuf; +int r; + +memset(tbuf, 0, sizeof(tbuf)); Please initialize this with = {} while declaring,

Re: [systemd-devel] [PATCH] Add timesync-wait tool

2014-10-23 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 23, 2014 at 09:24:06PM +0200, Łukasz Stelmach wrote: --- src/timesync/timesync-wait.c | 43 +++ 1 file changed, 43 insertions(+) create mode 100644 src/timesync/timesync-wait.c I am afraid TFD_TIMER_CANCEL_ON_SET doesn't help much here.

Re: [systemd-devel] [PATCH] Add timesync-wait tool

2014-10-23 Thread Tom Gundersen
On Thu, Oct 23, 2014 at 9:24 PM, Łukasz Stelmach stl...@poczta.fm wrote: --- src/timesync/timesync-wait.c | 43 +++ 1 file changed, 43 insertions(+) create mode 100644 src/timesync/timesync-wait.c I am afraid TFD_TIMER_CANCEL_ON_SET doesn't help much

Re: [systemd-devel] [PATCH] Add timesync-wait tool

2014-10-23 Thread Lennart Poettering
On Thu, 23.10.14 21:24, Łukasz Stelmach (stl...@poczta.fm) wrote: +int main(int argc, char *argv[]) { +struct timex tbuf; +int r; + +memset(tbuf, 0, sizeof(tbuf)); Please initialize this with = {} while declaring, instead of using memset() here. +r =

Re: [systemd-devel] [PATCH] Add timesync-wait tool

2014-10-23 Thread Ronny Chevalier
2014-10-23 21:24 GMT+02:00 Łukasz Stelmach stl...@poczta.fm: --- src/timesync/timesync-wait.c | 43 +++ 1 file changed, 43 insertions(+) create mode 100644 src/timesync/timesync-wait.c I am afraid TFD_TIMER_CANCEL_ON_SET doesn't help much here. You